Skip to content

feat(barotrauma): Migrate to use dedicated server appid#2403

Merged
dgibbs64 merged 2 commits intoGameServerManagers:hotfix/v19.7.1from
Morb0:develop
Jun 20, 2019
Merged

feat(barotrauma): Migrate to use dedicated server appid#2403
dgibbs64 merged 2 commits intoGameServerManagers:hotfix/v19.7.1from
Morb0:develop

Conversation

@Morb0
Copy link
Copy Markdown
Contributor

@Morb0 Morb0 commented Jun 20, 2019

Description

Barotrauma now has feature installing dedicated server with steamcmd as an anonymous user.
Use new appid for installing a server without steam auth.

Fixes #2402

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: Morbo <14136326+Morb0@users.noreply.github.com>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.

When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

fixes

@dgibbs64
Copy link
Copy Markdown
Member

I will hotfix this one

@dgibbs64 dgibbs64 added priority Top priority issues type: refactor labels Jun 20, 2019
@dgibbs64 dgibbs64 changed the title Use Barotrauma dedicated server tool feat(barotrauma): Migrate to use dedicated server appid Jun 20, 2019
@dgibbs64
Copy link
Copy Markdown
Member

@0ArturkA please add your email address so I can squash commit. Thank you

@Morb0
Copy link
Copy Markdown
Contributor Author

Morb0 commented Jun 20, 2019

@dgibbs64 yep

@dgibbs64 dgibbs64 changed the base branch from develop to hotfix/v19.7.1 June 20, 2019 23:00
@dgibbs64 dgibbs64 merged commit af50e2a into GameServerManagers:hotfix/v19.7.1 Jun 20, 2019
@dgibbs64 dgibbs64 added this to the v19.8.0 milestone Jun 21, 2019
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

priority Top priority issues type: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants