Allow setting of level for, e.g. HapisIsland, or levelurl for custom maps#2434
Closed
RFC1920 wants to merge 3 commits intoGameServerManagers:developfrom
Closed
Allow setting of level for, e.g. HapisIsland, or levelurl for custom maps#2434RFC1920 wants to merge 3 commits intoGameServerManagers:developfrom
RFC1920 wants to merge 3 commits intoGameServerManagers:developfrom
Conversation
Member
|
Looks good. I prefer to avoid too many if statements in the config though. I might move the if's to a module instead. It may also need to be sorted alongside the extra parms pr #2183 |
Author
|
FWIW the section I changed here was an if/else structure. Agreed it should probably be somewhere else and also include the extraparms from #2183. |
dgibbs64
requested review from
a team and
Frisasky
and removed request for
Frisasky
Member
|
Need an opinion on this from a Rust admin |
h3o66
added
the
branch conflicts
Member
|
Features of this PR have been added via #2711 Thank you |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to easily choose a custom level or custom map.