Skip to content

fix(core_messages.sh): use the proper variable to identify script source for logged events #2798

Closed
codingWithJimmy wants to merge 3 commits intoGameServerManagers:developfrom
codingWithJimmy:develop
Closed

fix(core_messages.sh): use the proper variable to identify script source for logged events #2798
codingWithJimmy wants to merge 3 commits intoGameServerManagers:developfrom
codingWithJimmy:develop

Conversation

@codingWithJimmy
Copy link
Copy Markdown
Contributor

@codingWithJimmy codingWithJimmy commented Apr 2, 2020

Update to allow script action name to appear in log correctly.

Description

After digging into this issue, I found that "core_messages.sh" was using the incorrect variable for identifying which script was producing output in the script log.

Fixes #2797

Type of change

  • Small code update to correct the variable in core_messages.sh

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

Update to allow action name to appear in log correctly.
@pull-assistant
Copy link
Copy Markdown

pull-assistant Bot commented Apr 2, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     Update core_messages.sh

     Revert "Update core_messages.sh"

     Revert "Revert "Update core_messages.sh""

Powered by Pull Assistant. Last update 876288e ... 4e1911d. Read the comment docs.

@codingWithJimmy
Copy link
Copy Markdown
Contributor Author

Closing request to format correctly

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant