Skip to content

fix(alert): resolve bug with telegram curlcustomstring error#2805

Merged
dgibbs64 merged 1 commit intoGameServerManagers:developfrom
RuioWolf:develop
Apr 4, 2020
Merged

fix(alert): resolve bug with telegram curlcustomstring error#2805
dgibbs64 merged 1 commit intoGameServerManagers:developfrom
RuioWolf:develop

Conversation

@RuioWolf
Copy link
Copy Markdown
Contributor

@RuioWolf RuioWolf commented Apr 3, 2020 •
edited
Loading

Description

I'm getting this error while trying to use curlcustomstring="--socks5 192.168.191.1:6080" as proxy:

[ .... ] Alert tf2server: Sending Telegram alertcurl: option --socks5 192.168.191.1:6080 : is unknown
curl: try 'curl --help' or 'curl --manual' for more information

So I make a fix for it. As far as I'm concerned, if curlcustomstring contains multiple option it should not use that quotes. I tested on my CentOS 7.6 with curl 7.29.0 and it works well.

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

No need.

@RuioWolf
fix curl: option is unknown
7549431 
I'm getting this error while trying to use `curlcustomstring="--socks5 192.168.191.1:6080"` as proxy: 
```shell
[ .... ] Alert tf2server: Sending Telegram alertcurl: option --socks5 192.168.191.1:6080 : is unknown
curl: try 'curl --help' or 'curl --manual' for more information
```
So I make a fix for it. As far as I'm concerned, if `curlcustomstring` contains multiple option it should not use that *quotes*.
@pull-assistant
Copy link
Copy Markdown

pull-assistant Bot commented Apr 3, 2020

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     fix curl: option is unknown

Powered by Pull Assistant. Last update 7549431 ... 7549431. Read the comment docs.

@dgibbs64 dgibbs64 added this to the v20.2.0 milestone Apr 4, 2020
@dgibbs64 dgibbs64 changed the title fix curl: option is unknown fix(alert): resolve bug with telegram curlcustomstring error Apr 4, 2020
@dgibbs64 dgibbs64 added type: bug Something isn't working info: alerts labels Apr 4, 2020
@dgibbs64 dgibbs64 merged commit 147057e into GameServerManagers:develop Apr 4, 2020
@RuioWolf RuioWolf mentioned this pull request Feb 9, 2021
Merged
13 tasks
@RuioWolf RuioWolf mentioned this pull request Feb 21, 2021
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 5, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

info: alerts type: bug Something isn't working

Projects

None yet

Milestone

v20.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@RuioWolf @dgibbs64