Skip to content

feat(stats): refactor to only use once curl and compact code#3116

Closed
h3o66 wants to merge 116 commits intoGameServerManagers:developfrom
h3o66:refactor/curl-stats
Closed

feat(stats): refactor to only use once curl and compact code#3116
h3o66 wants to merge 116 commits intoGameServerManagers:developfrom
h3o66:refactor/curl-stats

Conversation

@h3o66
Copy link
Copy Markdown
Member

@h3o66 h3o66 commented Nov 29, 2020

Description

Change to remove repeating code from info_stats.sh

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

AlasdairHaig and others added 30 commits June 21, 2020 13:25
Added Valheim to serverlistmenu.csv
Added Valheim specific stop command
Added Valheim entry to Serverlistmenu Table
@h3o66 h3o66 removed this from the v21.1.0 milestone Jan 14, 2021
@h3o66 h3o66 force-pushed the refactor/curl-stats branch from f8feecb to 3f3db61 Compare January 16, 2021 23:40
h3o66 and others added 4 commits January 17, 2021 22:04
* random seed

* correct name

* add seed to info_parms

* fix(wipe): resolve random seed not working
…#3164)

* feat(core): add new functions for github releases

* minor stuff

Co-authored-by: Daniel Gibbs <me@danielgibbs.co.uk>
@h3o66 h3o66 force-pushed the refactor/curl-stats branch from 3f3db61 to 09baa7a Compare January 18, 2021 22:11
@dgibbs64 dgibbs64 closed this Jan 27, 2021
@dgibbs64 dgibbs64 deleted the branch GameServerManagers:develop January 27, 2021 20:51
@h3o66 h3o66 reopened this Feb 7, 2021
@dgibbs64 dgibbs64 force-pushed the develop branch 5 times, most recently from f02e53d to 2257be4 Compare October 22, 2022 21:53
@h3o66 h3o66 closed this Apr 10, 2023
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants