Skip to content

fix: Fix Stop Command when console has pending input#3135

Closed
unknowntrojan wants to merge 1 commit intoGameServerManagers:masterfrom
unknowntrojan:patch-1
Closed

fix: Fix Stop Command when console has pending input#3135
unknowntrojan wants to merge 1 commit intoGameServerManagers:masterfrom
unknowntrojan:patch-1

Conversation

@unknowntrojan
Copy link
Copy Markdown
Contributor

@unknowntrojan unknowntrojan commented Dec 19, 2020

Description

When executing the stop command whilst something is still typed in the server session (enter was not pressed), the stop command will time out and fail, requiring manual intervention.

Type of change

This pull request simply "flushes" the command buffer by pressing enter. This may cause unintended behavior, such as a typed command getting implicitly executed, but the command will only have an impact on the game state if its persistent between restarts.

Properly execute quit when the session was improperly detached with something typed on the command line.
For example, someone types a command into the server console, then detaches. The stop command will wait, fail and need manual intervention.

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

Properly execute quit when the session was improperly detached with something typed on the command line.
For example, someone types a command into the server console, then detaches. The stop command will wait, fail and need manual intervention.
This should fix that.
@unknowntrojan unknowntrojan deleted the patch-1 branch December 19, 2020 15:30
@unknowntrojan unknowntrojan changed the title Fix Stop Command when console has pending input fix: Fix Stop Command when console has pending input Dec 23, 2020
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant