Skip to content

Feature/Steam Workshop support#4139

Merged
dgibbs64 merged 11 commits intoGameServerManagers:developfrom
FliesWithWind:feature/workshop-support
Apr 6, 2023
Merged

Feature/Steam Workshop support#4139
dgibbs64 merged 11 commits intoGameServerManagers:developfrom
FliesWithWind:feature/workshop-support

Conversation

@FliesWithWind
Copy link
Copy Markdown
Contributor

@FliesWithWind FliesWithWind commented Mar 13, 2023

Description

For a while, I had a horrible but working script for downloading and updating Arma 3 mods from Steam Workshop. I figured it was about time I try adding it to LinuxGSM. The script was based on https://github.com/arkmanager/ark-server-tools

Changes in this PR are working, but are far from being pretty or complete in my opinion. I'm no bash magician, so I wanted to show it as it is, hoping for an initial review and suggestions.

I've added it as a separate module, to avoid conflicts with the current mods module.
For now, it downloads mods for Arma 3 taken from the server config file.

workshopmods="450814997;2131302796"

Once we reach a working and pretty solution, the next steps would be to add support for other games, like Arc and Starboud, and add Steam Collections support.

Fixes #[3514] #[1894] #[1623] #[960]

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

Documentation will definitely need an update, once this is ready for merge. :)

@dgibbs64 dgibbs64 merged commit cbaf0af into GameServerManagers:develop Apr 6, 2023
@dgibbs64
Copy link
Copy Markdown
Member

dgibbs64 commented Apr 6, 2023

I did not mean to do that

@dgibbs64
Copy link
Copy Markdown
Member

dgibbs64 commented Apr 6, 2023

@FliesWithWind please can you open a new PR. I messed up

@FliesWithWind
Copy link
Copy Markdown
Contributor Author

Sure thing @dgibbs64. No worries :)

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants