fix: random seed not loading on reload of rustserver#4144
Closed
brorbw wants to merge 1 commit intoGameServerManagers:masterfrom
brorbw:master
Closed
fix: random seed not loading on reload of rustserver#4144brorbw wants to merge 1 commit intoGameServerManagers:masterfrom brorbw:master
brorbw wants to merge 1 commit intoGameServerManagers:masterfrom
brorbw:master
Conversation
Member
|
I believe this was fixed with this change https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/modules/info_game.sh#L1741 |
Author
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently I'm experiencing an issue where starting a rust server with the default configuration results in a seed of
2100762109consistently, regardless of what I do. Tried a freshVM, still same value. I suspect that it is due toseednot getting set correctly and ends up as0due toLinuxGSM/lgsm/functions/info_game.sh
Line 1477 in 51031eb
If I create a config that forces the seed
0I get the same seed in the logs. I suspect that its due to rust not handling a seed of 0, gracefully.If I do a
map-wipethe server gets the correct seed, but as I restart the server, it goes back to2100762109Changing the line
Also shows that the issue is that the seed value passed to rust is actually

0.Adding the line from this PR, creates the expected result

I'm very new to this project so consider this PR's more of an illustration of the issue, than an actual solution. I'm very open to criticism.
Maybe this needs some check for if the file exists. However that seems unnecessary since
command_install.shshould create a seed file.(maybe) Fixes #3832
Type of change
Checklist
PR will not be merged until all steps are complete.
developbranch as its base.Documentation
If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.
Thank you for your Pull Request!