Skip to content

fix(soulmask): add missing pigz package to dependencies#4605

Closed
intel44 wants to merge 1 commit intoGameServerManagers:developfrom
intel44:4604-smserver_add_pigz_pkg_for_backup
Closed

fix(soulmask): add missing pigz package to dependencies#4605
intel44 wants to merge 1 commit intoGameServerManagers:developfrom
intel44:4604-smserver_add_pigz_pkg_for_backup

Conversation

@intel44
Copy link
Copy Markdown
Contributor

@intel44 intel44 commented Jun 28, 2024

Description

add missing pigz package to dependencies. Required for backup

Fixes #4604

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

@MicLieg
Copy link
Copy Markdown
Contributor

MicLieg commented Jun 28, 2024

Thank you for the PR but it looks like pigz was already a part of the required dependencies for all games: https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/data/ubuntu-24.04.csv#L1C136-L1C140

Now it's listed redundantly for Soulmask.

@intel44
Copy link
Copy Markdown
Contributor Author

intel44 commented Jun 28, 2024

Pkg already as global requirements for lgsm, i close (info #4604 (comment))

@intel44 intel44 closed this Jun 28, 2024
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants