Skip to content

Few fixes [redux]#64

Closed
wrelam wants to merge 5 commits intoGameServerManagers:masterfrom
wrelam:master
Closed

Few fixes [redux]#64
wrelam wants to merge 5 commits intoGameServerManagers:masterfrom
wrelam:master

Conversation

@wrelam
Copy link
Copy Markdown

@wrelam wrelam commented Feb 4, 2014

-Added tickrate startup parameter
-Added print functions to declutter code
-Seperated startup parameters to one per line for readability/editability
-Removed addition of steam_appid.txt file since it is currently in question

@dgibbs64
Copy link
Copy Markdown
Member

dgibbs64 commented Feb 4, 2014

If you get really stuck I can make the changes myself. I will merge yours then update my changes right away :)

@wrelam
Copy link
Copy Markdown
Author

wrelam commented Feb 4, 2014

Completed the changes you requested. The default tickrate (if you don't use -tickrate) is 64 so that's why I chose it to being with. Users can then easily change it to 128 if they have the bandwidth to support it.

I see your point about the parms, but I don't think you should cater these scripts to people who don't know how to edit them. If they're gonna mess it up then they're gonna mess it up. I don't believe you should make it harder on the people maintaining the code (mainly you obviously, and anyone who wants to fork it). Just my thoughts.

@dgibbs64
Copy link
Copy Markdown
Member

dgibbs64 commented Feb 4, 2014

Thanks I will merge the code tomorrow :).

The variables section of the script is designed for the layman (n00b) who doesn't know how to code but wants to setup a game server (Sometimes they barely know how to use Linux). The script is designed the the end user first then the my convenience of maintaining it. If a person messes up the script they normally post a comment causing me more work. I think this is a trap some coders fall in to sometimes. The number one priority is that the end user gets the simplest experience possible. Besides only the variables section has to be like that. The rest of the script should never be edited my most people :). Thanks again for your work.

@dgibbs64 dgibbs64 self-assigned this Feb 4, 2014
@wrelam
Copy link
Copy Markdown
Author

wrelam commented Feb 4, 2014

No problem, it was extremely useful to me so I'm happy to be able to contribute back to it!

Totally understandable about the user experience. Maybe there is an easier way to interact with the user to get the information from them, similar to how you ask for the rcon password and server name.

@dgibbs64
Copy link
Copy Markdown
Member

dgibbs64 commented Feb 6, 2014

All these features have now been added to all the scripts. The print commands were particularly useful and the steam app fix is now in place on csgoserver. Thanks for your help

@dgibbs64 dgibbs64 closed this Feb 6, 2014
@lock
Copy link
Copy Markdown

lock Bot commented Jul 19, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants