Skip to content

monitor start#668

Closed
PhilPhonic wants to merge 46 commits intoGameServerManagers:masterfrom
PhilPhonic:monitorstart
Closed

monitor start#668
PhilPhonic wants to merge 46 commits intoGameServerManagers:masterfrom
PhilPhonic:monitorstart

Conversation

@PhilPhonic
Copy link
Copy Markdown
Contributor

ability to start a server if there is no lockfile

restart server if there is no lockfile and feature is enabled
added
added
added
added
added
added
added
added
added
added
added
added
added
added
added
added
added
added
added
added
added
added
added
added
@PhilPhonic
Copy link
Copy Markdown
Contributor Author

Couldn't test all servers, because I don't own all the games.
I think this should work for every game..

@dgibbs64
Copy link
Copy Markdown
Member

dgibbs64 commented Feb 2, 2016

Looks like this is a lockfiles bypass. What is your main reason for wanting this? The lockfile prevents monitor from starting back up if the user specifically stopped the server.

@PhilPhonic
Copy link
Copy Markdown
Contributor Author

The lockfile still can prevent monitor from starting the server when setting startonmonitor="off" (default).
There is no "reason" why I'm wanting this feature, I just thought it would be helpful. Perhaps there is a constellation of thingst that can happen, where the server crashes and the lockfile is removed? In this case monitor would restart the server.
If there is no way this could happen, just deny my pull request ;)

@dgibbs64
Copy link
Copy Markdown
Member

dgibbs64 commented Feb 2, 2016

the lock file is only removed on stop and created with start. The only way there could be an issue is if the user deleted the lock file and the monitor would stop working.

If the server crashes and reboots the lockfile still exists so monitor will then start the server again.

I will deny this pull request on this occasion :)

@dgibbs64 dgibbs64 closed this Feb 2, 2016
@PhilPhonic PhilPhonic deleted the monitorstart branch February 2, 2016 22:43
@lock
Copy link
Copy Markdown

lock Bot commented Jul 19, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants