Skip to content

Add variable to set email's sender 'emailfrom'#853

Closed
jakubsuchybio wants to merge 1 commit intoGameServerManagers:masterfrom
jakubsuchybio:master
Closed

Add variable to set email's sender 'emailfrom'#853
jakubsuchybio wants to merge 1 commit intoGameServerManagers:masterfrom
jakubsuchybio:master

Conversation

@jakubsuchybio
Copy link
Copy Markdown

@jakubsuchybio jakubsuchybio commented May 31, 2016

Hi,
on our server the default sender mail was awful, so I tweaked your alert_email, that it can now send emails with given sender set in new property 'emailfrom'
Regards Jacob

@UltimateByte
Copy link
Copy Markdown
Contributor

I like that, it could prevent spam detection. However, if it works, the variable should be added to all game servers.

@jakubsuchybio
Copy link
Copy Markdown
Author

Yes, I thought, that it would need to be applied to all servers. Ok, I will update the PR.
I tried it and it worked. Would you like some proof of it? I don't think I am that good to write some tests, but I can show some pictures of it working. If it would be enough.

@dgibbs64
Copy link
Copy Markdown
Member

Is there going to be a pull request for this?

@lock
Copy link
Copy Markdown

lock Bot commented Jul 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants