Skip to content

Mumble full rework#947

Merged
dgibbs64 merged 60 commits intomasterfrom
mumble-git-dl
Jul 29, 2016
Merged

Mumble full rework#947
dgibbs64 merged 60 commits intomasterfrom
mumble-git-dl

Conversation

@UltimateByte
Copy link
Copy Markdown
Contributor

I've added install, update, monitoring functions, fixed start, stop and details functions...
Everything is now working fine during my testing.

More than fixes #745

@UltimateByte
Copy link
Copy Markdown
Contributor Author

UltimateByte commented Jul 27, 2016

Note this change to the core_dl, otherwise it couldn't download from github. Took me ages to figure this bad boy out. b0253a9

Also, i'm not sure about glibc requirement. As it seems like it requires an old version, i set it at "non required" for now, we'll see if anyone complains about it being not compatible.

@dgibbs64
Copy link
Copy Markdown
Member

WOW. I will look at all this work as soon a possible :)

@dgibbs64
Copy link
Copy Markdown
Member

I will do a full test and check all the code before a commit. Probably not a good idea to commit when tired. At quick glance looks decent :D

@UltimateByte
Copy link
Copy Markdown
Contributor Author

UltimateByte commented Jul 27, 2016

You're right :)
Maybe displayed messages could be improved while updating, you'll see.
To simulate an update, like for TS, you can change the version number in the last log.

Saving you some time :
https://raw.githubusercontent.com/dgibbs64/linuxgsm/mumble-git-dl/Mumble/mumbleserver
Don't forget to change the branch to mumble-git-dl

Crap, speaking of logs, i'm thinking now there won't have any due to the fact that it's not using tmux anymore... Brrrr ! Now i need to find a workaround. I'll probably use tmux anyways then, will have to rework start and stop, again.

Edit : Problem solved, was quite easy actually. Solved another minor thing in mumbleserver main script.

Comment thread lgsm/functions/update_mumble.sh Outdated
echo -e "copying to ${filesdir}...\c"
fn_script_log "Copying to ${filesdir}"
cp -R "${lgsmdir}/tmp/murmur-static_${mumblearch}-${availablebuild}/"* "${filesdir}"
rm -R "${lgsmdir}/tmp"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting : Is there a function removing the temp dir that i don't know ? :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tmp dir does not get removed currently. However that may change at some point

…-git-dl

# Conflicts:
#	lgsm/functions/command_details.sh
#	lgsm/functions/command_install.sh
#	lgsm/functions/command_stop.sh
#	lgsm/functions/info_config.sh
@dgibbs64
Copy link
Copy Markdown
Member

Im testing this currently. Should be able to merge soon :)

@dgibbs64 dgibbs64 merged commit d887160 into master Jul 29, 2016
@dgibbs64
Copy link
Copy Markdown
Member

Awesome work. Mumble server has never been better!!!

@dgibbs64 dgibbs64 deleted the mumble-git-dl branch July 29, 2016 22:27
@UltimateByte
Copy link
Copy Markdown
Contributor Author

Thanks ! It really needed it; most functions were not working, it was pretty much unusable.
My checklist is finally getting smaller and smaller :o))

@lock
Copy link
Copy Markdown

lock Bot commented Jul 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mumbleserver] Stop doesnt work|Missing parameter in script

2 participants