disable log flushing when not actively working (telemetry or tracking)#638
Open
planetchili wants to merge 1 commit into
Open
disable log flushing when not actively working (telemetry or tracking)#638planetchili wants to merge 1 commit into
planetchili wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces idle CPU/battery usage in the PresentMon service by preventing the log system’s periodic flush thread from waking up when the service isn’t doing active work (tracking or telemetry/metric usage), addressing idle wakeups noted in #623.
Changes:
- Add a service API to enable/disable periodic log flushing at runtime.
- Extend
ChannelFlusherto support an enabled/disabled state (blocking indefinitely while disabled). - Toggle periodic flushing based on whether any session is actively tracking PIDs or using device metrics.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| IntelPresentMon/PresentMonService/LogSetup.h | Exposes SetPeriodicLogFlushingEnabled() for the service. |
| IntelPresentMon/PresentMonService/LogSetup.cpp | Constructs ChannelFlusher initially disabled; adds runtime toggle function. |
| IntelPresentMon/PresentMonService/acts/StartTracking.h | Enables periodic flushing when tracking begins (via context update). |
| IntelPresentMon/PresentMonService/acts/StopTracking.h | Updates periodic flushing state when tracking ends. |
| IntelPresentMon/PresentMonService/ActionExecutionContext.h | Declares UpdatePeriodicLogFlushing(). |
| IntelPresentMon/PresentMonService/ActionExecutionContext.cpp | Implements activity detection and toggles periodic flushing accordingly. |
| IntelPresentMon/CommonUtilities/log/ChannelFlusher.h | Adds enabled state + signaling members for suspending/resuming flush loop. |
| IntelPresentMon/CommonUtilities/log/ChannelFlusher.cpp | Implements blocking wait while disabled, with wake-on-state-change and optional “flush before suspend”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pChannel->AttachComponent(std::make_shared<StdioDriver>(pFormatter), "drv:std"); | ||
| // flusher | ||
| pChannel->AttachComponent(std::make_shared<ChannelFlusher>(pChannel), "obj:fsh"); | ||
| pChannel->AttachComponent(std::make_shared<ChannelFlusher>(pChannel, false), "obj:fsh"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improves idle battery consumption
closes #623