Skip to content

Testplans for the Bugfinder#104

Merged
delvh merged 10 commits intomainfrom
documentation/test-plans-bugfinder
Aug 6, 2022
Merged

Testplans for the Bugfinder#104
delvh merged 10 commits intomainfrom
documentation/test-plans-bugfinder

Conversation

@madebyTimo
Copy link
Contributor

@madebyTimo madebyTimo commented Aug 5, 2022

@madebyTimo madebyTimo added the documentation Improvements or additions to documentation label Aug 5, 2022
@madebyTimo madebyTimo requested a review from delvh as a code owner August 5, 2022 16:59
@madebyTimo madebyTimo self-assigned this Aug 5, 2022
delvh
delvh reviewed Aug 5, 2022
View reviewed changes
Copy link
Contributor

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General tips:

  • You don't need in your procedure what you mentioned in the precondition.
  • In general, try to avoid being to specific. That only means that your testcases won't work anymore if you change your application slightly.
  • snipped -> snippet

delvh
delvh previously approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Probably because I rewrote it until I couldn't find a mistake anymore... )

@delvh delvh requested review from cdingm and maexled August 6, 2022 14:04
@delvh
Copy link
Contributor

delvh commented Aug 6, 2022 •
edited
Loading

Deadline for new reviews is tonight@23:00 so that the issue can be closed today. Our Burndown chart looks already bad enough in this sprint.

cdingm
cdingm previously approved these changes Aug 6, 2022
View reviewed changes
maexled
maexled reviewed Aug 6, 2022
View reviewed changes
Copy link
Contributor

@maexled maexled left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other things I have noticed:
cancel-bug-submission -> replace cancel to undo or revert, cancel is in my opinion when you have the modal open to specify a bug, but you hit cancel (we also have no test plan for this, I do not know if we need this)

Also on one point it is bug-selection, but the other bug-submission

@delvh
Copy link
Contributor

delvh commented Aug 6, 2022

Also on one point it is bug-selection, but the other bug-submission

Are you referring to u-2 and u-3?
If yes, that's because they talk about two separate actions, hence selection is more fitting for u-2 while submission is more fitting for u-3.

@delvh delvh dismissed stale reviews from cdingm and themself via 079df8e August 6, 2022 17:10
@delvh
Copy link
Contributor

delvh commented Aug 6, 2022

Regardless, submission in u.bugfinder-3 has now been changed to correction.

@delvh delvh merged commit 72ad57d into main Aug 6, 2022
@delvh delvh deleted the documentation/test-plans-bugfinder branch August 6, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maexled maexled maexled approved these changes

@delvh delvh delvh approved these changes

@cdingm cdingm cdingm left review comments

Assignees

@madebyTimo madebyTimo

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Testing: Testplans for the Bugfinder

4 participants

@madebyTimo @delvh @maexled @cdingm