Skip to content

Add regex game test plans#108

Merged
delvh merged 5 commits intomainfrom
regex-game-frontend-test
Aug 11, 2022
Merged

Add regex game test plans#108
delvh merged 5 commits intomainfrom
regex-game-frontend-test

Conversation

@leonleoff
Copy link
Contributor

@leonleoff leonleoff commented Aug 9, 2022

@leonleoff leonleoff requested review from delvh and madebyTimo August 9, 2022 07:52
@cdingm cdingm self-requested a review August 9, 2022 09:16
Copy link
Collaborator

@cdingm cdingm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments. We discussed that alternative procedure is not the bugs that could occur

@delvh delvh changed the title Regex game frontend test Regex game test plans Aug 9, 2022
Co-authored-by: cdingm <101562444+cdingm@users.noreply.github.com>
@cdingm cdingm self-requested a review August 9, 2022 10:22
cdingm
cdingm previously approved these changes Aug 9, 2022
Copy link
Contributor

@IlijazM IlijazM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@delvh delvh requested a review from IlijazM August 9, 2022 19:17
@delvh delvh changed the title Regex game test plans Add regex game test plans Aug 10, 2022
Copy link
Contributor

@Gr33ndev Gr33ndev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@delvh
Copy link
Contributor

delvh commented Aug 11, 2022

I got no response to the answers as to why the requested changes won't be implemented.
Especially as @IlijazM will be unavailable until the end of the sprint, I'll merge the PR now.

@delvh delvh merged commit 90e4500 into main Aug 11, 2022
@delvh delvh deleted the regex-game-frontend-test branch August 11, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing: Testplans for the Regex Game

6 participants