Add Overworld test plans by WuestFlorian · Pull Request #112 · Gamify-IT/docs

WuestFlorian · 2022-08-10T08:18:43Z

Rename to differentiate between minigame use cases and the overworld frontend minigame spot

The test case gets split up into one for a configurated minigame and one for a minigame spot without a configurated backend.

Test case split up to one for an active barrier and one for an inactive one.

cdingm · 2022-08-10T08:52:55Z

i commited the HUD tests, so i changed the comment again. But we should be sure that there are no more test plans needed before merging

Gr33ndev

All test plans lgtm, I also tested them on my laptop.

Tested on: MacBook Pro 2020 m1 13" - macOS Monterey 12.5 - Firefox 103.0.2 (64-Bit) - Testdeploy Server

U.area.1 -> works
U.area.2 -> not checked

U.barrier.1 -> works
U.barrier.2 -> you can walk to area 2 even when the barrier is set because of the updated hitboxes
U.barrier.3 -> works but same as U.barrier.2

U.dungeon.1 -> works

U.hud.1 -> works
U.hud.2 -> works
U.hud.3 -> minimap zoom works as intended - overworld zoom level 1 and 2 is identical for me, level 3 zooms far out
U.hud.4 -> works
U.hud.5 -> works

U.minigame.1 -> minigamespot isn't blue - everything else works
U.minigame.2 -> works
U.minigame.3 -> works
U.minigame.4 -> works

U.object.1 -> not checked

delvh

I'll leave the formalities of complying with the template again up to you.

delvh · 2022-08-10T08:30:36Z

dev-manuals/test-plans/overworld-frontend/plans/area-colliders.md

@@ -0,0 +1,35 @@
+# Name: Area colliders


Should probably be split up into separate testplans per area,
maybe even with this testplan being refactored into a summary of the other testplans.

dev-manuals/test-plans/overworld-frontend/plans/area-colliders.md

dev-manuals/test-plans/overworld-frontend/plans/minigame-spot-not-configurated.md

dev-manuals/test-plans/overworld-frontend/plans/barrier-active-player-not-unlocked.md

dev-manuals/test-plans/overworld-frontend/plans/barrier-active-world-not-active.md

dev-manuals/test-plans/overworld-frontend/plans/pause-menu-function.md

delvh · 2022-08-10T14:41:33Z

dev-manuals/test-plans/overworld-frontend/plans/minimap-functions.md

+8. The tester zooms out the game with the keybind and checks if the minimap also zoomed out
+9. The tester zooms in the game with the keybind and checks if the minimap also zoomed in


Isn't that already in another test plan?

yes, but rather be safe then sorry no?

Why test it twice?
Doesn't that only waste time?

Especially if we test for multiple OSs?

delvh · 2022-08-10T14:45:48Z

dev-manuals/test-plans/overworld-frontend/plans/minimap-functions.md

+1. The tester checks if the Player head is always in the middle of the minimap by walking around
+2. The tester zooms in the minimap with the keybind
+3. The tester zooms out the minimap with the keybind
+4. The tester zooms in the minimap with the button
+5. The tester zooms out the minimap with the button
+6. The tester checks if there are always 4 zoom levels
+7. The tester walks around and checks if the minimap displays npc heads and area symbols
+8. The tester zooms out the game with the keybind and checks if the minimap also zoomed out
+9. The tester zooms in the game with the keybind and checks if the minimap also zoomed in
+10. The tester walks around with different zoom levels and checks the minimap if everything is displayed correctly
+
+## Alternative procedures
+
+N/A


Suggested change

1. The tester checks if the Player head is always in the middle of the minimap by walking around

2. The tester zooms in the minimap with the keybind

3. The tester zooms out the minimap with the keybind

4. The tester zooms in the minimap with the button

5. The tester zooms out the minimap with the button

6. The tester checks if there are always 4 zoom levels

7. The tester walks around and checks if the minimap displays npc heads and area symbols

8. The tester zooms out the game with the keybind and checks if the minimap also zoomed out

9. The tester zooms in the game with the keybind and checks if the minimap also zoomed in

10. The tester walks around with different zoom levels and checks the minimap if everything is displayed correctly

## Alternative procedures

N/A

1. Check that the Player head is always in the middle of the minimap when walking around

2. Zoom in the minimap with the shortcut

3. Zoom out the minimap with the shortcut

4. Check that there is a finite and constant amount of zoom levels

5. Walk around and check if the minimap displays NPC heads and area symbols

6. Walk around with different zoom levels and check on the minimap if everything is displayed correctly and no world borders are visible

## Alternative procedures

2.1. zoom in using the button \

3.1. zoom out using the button

dev-manuals/test-plans/overworld-frontend/plans/minigame-spot-not-configurated.md

delvh · 2022-08-10T14:49:43Z

dev-manuals/test-plans/overworld-frontend/plans/minigame-spot-configured-not-done.md

@@ -0,0 +1,39 @@
+# Name: Minigame spot configured and not done


Can be deleted then.

delvh · 2022-08-10T14:59:57Z

U.area.1 -> works U.area.2 -> not checked

U.barrier.1 -> works U.barrier.2 -> you can walk to area 2 even when the barrier is set because of the updated hitboxes U.barrier.3 -> works but same as U.barrier.2

U.dungeon.1 -> works

U.hud.1 -> works U.hud.2 -> works U.hud.3 -> minimap zoom works as intended - overworld zoom level 1 and 2 is identical for me, level 3 zooms far out U.hud.4 -> works U.hud.5 -> works

U.minigame.1 -> minigamespot isn't blue - everything else works U.minigame.2 -> works U.minigame.3 -> works U.minigame.4 -> works

U.object.1 -> not checked

Copied your test results into the execution log. Next time, please do it yourself.

Gr33ndev · 2022-08-10T15:02:56Z

Copied your test results into the execution log. Next time, please do it yourself.

Thank you, I had tried that, but unfortunately the sheet is locked...

delvh · 2022-08-10T15:04:58Z

(Google only displays it like that. I've explicitly excluded the columns A-G.)

Gr33ndev · 2022-08-10T15:06:23Z

Oh ok, sorry... I didn't know that....

Co-authored-by: delvh <dev.lh@web.de>

Apply suggestions from delvh Co-authored-by: delvh <dev.lh@web.de>

delvh · 2022-08-11T15:31:34Z

...als/test-plans/overworld-frontend/plans/u-overworld-03-barrier-active-player-not-unlocked.md

@@ -0,0 +1,35 @@
+# Overworld: Barrier block locked worlds (`u.overworld-3`)


Suggested change

# Overworld: Barrier block locked worlds (`u.overworld-3`)

# Overworld: Barriers block locked worlds (`u.overworld-03`)

Also, the file name should be adapted to the action as well...

dev-manuals/test-plans/overworld-frontend/plans/u-overworld-01-world-transition-loading.md

dev-manuals/test-plans/overworld-frontend/plans/u-overworld-02-dungeon-entrance-exit.md

...anuals/test-plans/overworld-frontend/plans/u-overworld-04-barrier-active-world-not-active.md

dev-manuals/test-plans/overworld-frontend/plans/u-overworld-05-barrier-inactive.md

dev-manuals/test-plans/overworld-frontend/plans/u-overworld-06-npc-combined.md

dev-manuals/test-plans/overworld-frontend/plans/u-overworld-07-load-npc-texts-from-backend.md

dev-manuals/test-plans/overworld-frontend/plans/u-overworld-09-mark-npc-as-talked-to.md

delvh · 2022-08-11T15:40:11Z

Preferably, these paddings can even be added to the linkages, but that is absolutely optional, as sorting should work correctly as the filenames are padded.

...als/test-plans/overworld-frontend/plans/u-overworld-03-barrier-active-player-not-unlocked.md

Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Gr33nbl00d <st172032@stud.uni-stuttgart.de>

delvh · 2022-08-11T22:43:21Z

When do we merge?

delvh · 2022-08-11T23:06:24Z

Deadline for further comments: Today@3pm

WuestFlorian and others added 20 commits August 3, 2022 13:19

Create minigame test case

ef1c87a

Rename use case

d34f60f

Rename to differentiate between minigame use cases and the overworld frontend minigame spot

Create barrier use case

0dbb496

Create dungeon entrance and exit test plan

cdb225a

spelling fix and md fix

82f1949

Create minigame loading test plan

c1c570d

Rename and exclude minigame starting

5677baa

Split up test case

24754c6

The test case gets split up into one for a configurated minigame and one for a minigame spot without a configurated backend.

Create minigame spot not configurated test plan

d9dd9d5

Convert test case (minigame spot not configurated) to md

2090f19

Change test case number

c9c2ecd

Split up test case

9ca06e1

Test case split up to one for an active barrier and one for an inactive one.

Create barrier-inactive.md

d001ef5

Change post condition and name

e39f183

Remove wrong alternative procedures

e9d4be8

Remove wrong alternative procedures

8944760

Split up test plans and improve existing ones

7688bb6

Add world transition and colliders test plans

8213e02

spelling fixes, some additions, grammar fixes, markdown fixes

1f5dc5e

create first version of objects colliders test case

ba991be

WuestFlorian requested review from Aaron2000119, Gr33ndev, IlijazM, LeviUniAcc, cdingm, delvh, leonleoff, madebyTimo, maexled and robojones August 10, 2022 08:18

cdingm added 4 commits August 10, 2022 10:30

add minimap test case

b069600

add area name function plan

1b85656

add game zoom test case

6e19b77

add pause menu tests

8ba5f2f

cdingm requested review from Gr33ndev, IlijazM and robojones August 10, 2022 09:22

Gr33ndev previously approved these changes Aug 10, 2022

View reviewed changes

delvh reviewed Aug 10, 2022

View reviewed changes

Apply suggestions from code review

b6e4af6

Co-authored-by: delvh <dev.lh@web.de>

cdingm dismissed Gr33ndev’s stale review via b6e4af6 August 10, 2022 20:46

WuestFlorian and others added 2 commits August 11, 2022 14:19

Apply suggestions from code review

d0c7247

Apply suggestions from delvh Co-authored-by: delvh <dev.lh@web.de>

Adapt to new template

3c7767e

Gr33ndev approved these changes Aug 11, 2022

View reviewed changes

delvh approved these changes Aug 11, 2022

View reviewed changes

Gr33ndev approved these changes Aug 11, 2022

View reviewed changes

...als/test-plans/overworld-frontend/plans/u-overworld-03-barrier-active-player-not-unlocked.md Outdated Show resolved Hide resolved

LeviUniAcc approved these changes Aug 11, 2022

View reviewed changes

Apply suggestions from code review

ef5aab9

Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Gr33nbl00d <st172032@stud.uni-stuttgart.de>

cdingm approved these changes Aug 11, 2022

View reviewed changes

Gr33ndev merged commit 82829ef into main Aug 12, 2022

Gr33ndev deleted the dokumentation/overworld-test-plans branch August 12, 2022 10:54

		8. The tester zooms out the game with the keybind and checks if the minimap also zoomed out
		9. The tester zooms in the game with the keybind and checks if the minimap also zoomed in

		@@ -0,0 +1,39 @@
		# Name: Minigame spot configured and not done

		@@ -0,0 +1,35 @@
		# Overworld: Barrier block locked worlds (`u.overworld-3`)

	# Overworld: Barrier block locked worlds (`u.overworld-3`)
	# Overworld: Barriers block locked worlds (`u.overworld-03`)

Conversation

WuestFlorian commented Aug 10, 2022 • edited by cdingm Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cdingm commented Aug 10, 2022

Uh oh!

Gr33ndev left a comment

Choose a reason for hiding this comment

Uh oh!

delvh left a comment

Choose a reason for hiding this comment

Uh oh!

delvh Aug 10, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

delvh Aug 10, 2022

Choose a reason for hiding this comment

Uh oh!

cdingm Aug 10, 2022

Choose a reason for hiding this comment

Uh oh!

delvh Aug 10, 2022

Choose a reason for hiding this comment

Uh oh!

delvh Aug 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

delvh Aug 10, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

delvh Aug 10, 2022

Choose a reason for hiding this comment

Uh oh!

delvh commented Aug 10, 2022

Uh oh!

Gr33ndev commented Aug 10, 2022

Uh oh!

delvh commented Aug 10, 2022

Uh oh!

Gr33ndev commented Aug 10, 2022

Uh oh!

delvh Aug 11, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

delvh commented Aug 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

delvh commented Aug 11, 2022

Uh oh!

delvh commented Aug 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

WuestFlorian commented Aug 10, 2022 •

edited by cdingm

Loading

delvh Aug 10, 2022 •

edited

Loading

delvh commented Aug 11, 2022 •

edited

Loading