Merged
Conversation
3 tasks
madebyTimo
reviewed
Jun 29, 2022
Contributor
madebyTimo
left a comment
madebyTimo
left a comment
There was a problem hiding this comment.
good work overall, but some things can be enhanced
|
|
||
| services: | ||
| sonarqube: | ||
| image: sonarqube:community |
Contributor
There was a problem hiding this comment.
Suggested change
| image: sonarqube:community | |
| image: sonarqube:community | |
| restart: always |
| ports: | ||
| - "9000:9000" | ||
| db: | ||
| image: postgres:12 |
Contributor
There was a problem hiding this comment.
Suggested change
| image: postgres:12 | |
| image: postgres:12 | |
| restart: always |
| ports: | ||
| - "9000:9000" | ||
| db: | ||
| image: postgres:12 |
Contributor
There was a problem hiding this comment.
Why using postgres 12 and not postgres 14?
Comment on lines
112
to
113
| docker update --restart always sonardocker_db_1 | ||
| docker update --restart always sonardocker_sonarqube_1 |
Contributor
There was a problem hiding this comment.
Suggested change
| docker update --restart always sonardocker_db_1 | |
| docker update --restart always sonardocker_sonarqube_1 |
Comment on lines
117
to
120
| crontab -e | ||
| -> add | ||
| @reboot docker start sonardocker_db_1 | ||
| @reboot docker start sonardocker_sonarqube_1 |
Contributor
There was a problem hiding this comment.
Suggested change
| crontab -e | |
| -> add | |
| @reboot docker start sonardocker_db_1 | |
| @reboot docker start sonardocker_sonarqube_1 |
with dockers restart always the containers automatically should restart after a reboot
Contributor
|
Is there also a reverse-proxy configuration to access sonarqube? With this configuration it only runs at port 9000, isn't it? |
Contributor
Author
|
The reverse proxy from the first installation still exists unchanged |
delvh
approved these changes
Jun 30, 2022
delvh
changed the title
Contributor
|
what is about the suggestions from the last review? |
Contributor
|
Those still have to be applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gamify-IT/issues#58