Skip to content

ADR: How to handle minigame configuration ID as URL route#83

Merged
delvh merged 2 commits intomainfrom
documentation/minigame-configuration-id
Jul 20, 2022
Merged

ADR: How to handle minigame configuration ID as URL route#83
delvh merged 2 commits intomainfrom
documentation/minigame-configuration-id

Conversation

@madebyTimo
Copy link
Contributor

@madebyTimo madebyTimo commented Jul 17, 2022

please vote for your preference

@madebyTimo
Copy link
Contributor Author

👍 for insert the ID into the route

@madebyTimo
Copy link
Contributor Author

👍 for keep the old solution (URL fragent)

@madebyTimo madebyTimo self-assigned this Jul 17, 2022
Copy link
Contributor

@maexled maexled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insert the ID into the route

@delvh delvh added the ADR This PR adds/ modifies an ADR label Jul 17, 2022
@LeviUniAcc
Copy link
Member

Do i get it correctly, we Change the # With a $?

@delvh
Copy link
Contributor

delvh commented Jul 17, 2022

Do i get it correctly, we Change the # With a $?

Absolutely not.
The $ is simply meant to signify that what follows is a variable (most common way to clarify that something is a variable, most likely adopted from POSIX shells where that syntax accesses said variable).
What we do instead is pass the config ID as a path param instead of as URL fragment (you might have already heard about path params/ worked with them in Spring i.e. for PE2 or Sopra)

@delvh
Copy link
Contributor

delvh commented Jul 20, 2022

No activity here.
Merging now.

@delvh delvh merged commit 6e76ef4 into main Jul 20, 2022
@delvh delvh deleted the documentation/minigame-configuration-id branch July 20, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ADR This PR adds/ modifies an ADR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants