Skip to content

fix(workflows): apply workflow review guidelines across all workflows#19

Merged
Garbee merged 12 commits intomainfrom
copilot/review-github-workflows
Feb 14, 2026
Merged

fix(workflows): apply workflow review guidelines across all workflows#19
Garbee merged 12 commits intomainfrom
copilot/review-github-workflows

Conversation

Copy link
Contributor

Copilot AI commented Feb 14, 2026

  • Review all 5 workflow files against GitHub workflow review instructions
  • Fix must-fix issues (security & reliability)
    • Add missing timeout-minutes to all jobs (5 minutes for all jobs per repository requirements)
    • Fix runner version pinning (ubuntu-latest → ubuntu-24.04 in codeql.yml)
    • Fix concurrency settings (cancel-in-progress uses != 'push' for better coverage)
    • Add missing shell safety (set -euo pipefail) to all multi-line scripts
  • Address improvement issues (maintainability)
    • Fix step naming to use proper title case
    • Fix shell flags (euoC → euo in copilot-setup-steps.yml)
  • Validate all changes
    • All tests pass (38/38 tests passing)
    • All workflows syntax validated
  • Update workflow review instructions for consistency
  • Resolve merge conflicts with main branch

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Garbee <868301+Garbee@users.noreply.github.com>
Copilot AI changed the title [WIP] Update GitHub workflows based on review instructions fix(workflows): apply workflow review guidelines across all workflows Feb 14, 2026
Copilot AI requested a review from Garbee February 14, 2026 22:08
Update concurrency cancel-in-progress from == 'pull_request' to != 'push'
for better coverage of non-push events. Also updated instructions for consistency.

Co-authored-by: Garbee <868301+Garbee@users.noreply.github.com>
Per repository-specific requirements, all workflow jobs should complete
within 5 minutes. Updated all timeout-minutes from 10/20 to 5.

Co-authored-by: Garbee <868301+Garbee@users.noreply.github.com>
@Garbee
Copy link
Owner

Garbee commented Feb 14, 2026

@copilot resolve the merge conflicts

Resolved conflicts by keeping correct step order (checkout before telemetry)
from main while preserving title case improvements for step names.

Co-authored-by: Garbee <868301+Garbee@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 14, 2026

@copilot resolve the merge conflicts

Merge conflicts resolved in commit e7af793. The conflicts were in actionlint.yml and zizmor.yml where the step order differed (checkout vs telemetry first). Resolution kept the correct step order from main (checkout first, then telemetry) while preserving the title case improvements for step names.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Garbee Garbee marked this pull request as ready for review February 14, 2026 22:35
@Garbee Garbee merged commit e03ca28 into main Feb 14, 2026
11 checks passed
@Garbee Garbee deleted the copilot/review-github-workflows branch February 14, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants