Skip to content

resolve #245; separate integration tests to make recording optional#246

Merged
davidwyld merged 2 commits intodevfrom
optional_cypress_dash
Nov 16, 2022
Merged

resolve #245; separate integration tests to make recording optional#246
davidwyld merged 2 commits intodevfrom
optional_cypress_dash

Conversation

@davidwyld
Copy link
Copy Markdown
Contributor

Just duplicates the integration tests on github actions so that on pushes/pull requests they run without recording to cypress dashboard but we have a separate workflow for manually triggering the run that records.

@github-actions
Copy link
Copy Markdown

Jest Coverage

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 80.11 79.16 78.26 80.11
Details
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 80.11 79.16 78.26 80.11
_src/components 74.73 75.51 79.16 74.73
_ AnnotationRenderer.vue 73.62 75.51 76.19 73.62 114,123-124,178,201,221,228-242,250,256-266,283
_ MarkdownEditor.vue 100 100 100 100
_ MarkdownRenderer.vue 100 100 100 100
_src/components/annotation 78.57 86.66 76.47 78.57
_ CheckboxInput.vue 85.71 100 100 85.71 19
_ HtmlDisplay.vue 80 100 100 80 26-30
_ InputErrorDisplay.vue 100 0 100 100 19-25
_ RadioInput.vue 71.42 100 66.66 71.42 19,26
_ SelectorInput.vue 71.42 100 66.66 71.42 20,27
_ TextInput.vue 75 100 66.66 75 26
_ TextareaInput.vue 66.66 100 50 66.66 20
_src/enum 100 100 100 100
_ DocumentTypes.js 100 100 100 100
_src/jrpc 90.32 83.33 75 90.32
_ index.js 90.32 83.33 75 90.32 29,38-39
_src/utils 100 100 100 100
_ annotations.js 100 100 100 100
_tests/unit 100 100 100 100
_ globalVue.js 100 100 100 100

@twinkarma
Copy link
Copy Markdown
Collaborator

Looks sensible to me but I guess we can't be 100% sure if it will run until we merge it into the main branch?

@davidwyld
Copy link
Copy Markdown
Contributor Author

Looks sensible to me but I guess we can't be 100% sure if it will run until we merge it into the main branch?

Unfortunately, yes.

@twinkarma
Copy link
Copy Markdown
Collaborator

Ok let's merge it in and make a note to double check when this gets into master then.

@davidwyld davidwyld merged commit 9b4690d into dev Nov 16, 2022
@davidwyld davidwyld deleted the optional_cypress_dash branch November 16, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants