Conversation
…nd Annotations. Added tests for checking user delete.
Jest Coverage
Details
|
davidwyld
approved these changes
Mar 27, 2023
Contributor
davidwyld
left a comment
There was a problem hiding this comment.
Looks great! Nice one. Do we need some documentation?
This was referenced Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServiceUserto allow deleting of user's personal information:is_deletedflag for identifying deleted usersdelete_user_personal_information- Replaces user's information with placeholder information. Username is replaced withdeleted_[random hash string]both the prefix string and suffix hash length can be specified in the settings.base.pywith the default values:user_delete_personal_informationanduser_delete_accountadmin_delete_user_personal_informationandadmin_delete_userALLOW_USER_DELETEsettings must be true in order for theuser_delete_accountandadmin_delete_userto workloginrpc so that accounts markedis_deletedcannot login, raises anAuthErrorinitialiseRPC that's called when the app starts, it gets the user auth/role information, their config and the global config (ALLOW_USER_DELETE)get_possible_annotatorsnow excludes deleted usersuser_delete_personal_informationuser_delete_accountadmin_delete_user_personal_informationadmin_delete_user