Skip to content

Admin role should imply manager#321

Merged
twinkarma merged 1 commit intodevfrom
admin-implies-manager
Mar 15, 2023
Merged

Admin role should imply manager#321
twinkarma merged 1 commit intodevfrom
admin-implies-manager

Conversation

@ianroberts
Copy link
Copy Markdown
Member

It always did in is_authenticated but behaviour was not consistent in login

Closes #320

It always did in is_authenticated but behaviour was not consistent in login

Closes #320
@github-actions
Copy link
Copy Markdown

Jest Coverage

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 80 77.37 74.19 79.92
Details
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 80 77.37 74.19 79.92
_src/components 77.14 77.35 85.71 77.14
_ AnnotationRenderer.vue 76.23 77.35 84 76.23 126,141-142,196,219,240,247-261,269,275-285,319
_ MarkdownEditor.vue 100 100 100 100
_ MarkdownRenderer.vue 100 100 100 100
_src/components/annotation 80.95 86.66 82.35 80.95
_ CheckboxInput.vue 85.71 100 100 85.71 19
_ HtmlDisplay.vue 80 100 100 80 26-30
_ InputErrorDisplay.vue 100 0 100 100 19-25
_ RadioInput.vue 85.71 100 100 85.71 19
_ SelectorInput.vue 71.42 100 66.66 71.42 20,27
_ TextInput.vue 75 100 66.66 75 26
_ TextareaInput.vue 66.66 100 50 66.66 20
_src/enum 100 100 100 100
_ DocumentTypes.js 100 100 100 100
_src/jrpc 90.32 83.33 75 90.32
_ index.js 90.32 83.33 75 90.32 29,38-39
_src/utils 77.77 74.6 38.46 77.46
_ annotations.js 96.55 81.25 100 96.42 35
_ dict.js 100 100 100 100
_ index.js 55.88 54.54 11.11 55.88 9-14,28-93
_tests/unit 100 100 100 100
_ globalVue.js 100 100 100 100

@davidwyld davidwyld requested a review from twinkarma March 14, 2023 15:19
Copy link
Copy Markdown
Collaborator

@twinkarma twinkarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me, I'll merge it in

@twinkarma twinkarma merged commit 5a0659e into dev Mar 15, 2023
@ianroberts ianroberts deleted the admin-implies-manager branch April 14, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants