Draft
Conversation
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
dchansen06
added
Enhancement
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
dchansen06
force-pushed
the
ConversionWarnings
branch
2 times, most recently
from
0238246 to
de77fc5
Compare
Contributor
Author
|
Maybe out of scope for now, there are a lot of different things
See GCC 3.9 Options to Request or Suppress Warnings It may be worth reviewing the pages under GCC 3 Command Options |
dchansen06
added
3 NORMAL
3 tasks
coderask
added a commit
that referenced
this pull request
Apr 17, 2026
# Fix ECU performance data type ## Problem and Scope ECU performance was uint8 instead of uint32 ## Description This would break ECU code silently(no compile errors, but wrong type). ## Gotchas and Limitations ## Testing - [x] HOOTL testing - [ ] HITL testing - [x] Human tested ### Testing Details Looked at StructParser output ## Larger Impact Bugfix ## Additional Context and Ticket Related to #418 Resolves #417 --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conversion Warnings
Problem and Scope
Conversion warnings are not enabled, causes silent behavior
Description
Turn on
-Wconversionand fix bugsGotchas and Limitations
Some are just missing explicit casts
Testing
Testing Details
Compilation without warnings
Larger Impact
Depends on scale of changes
Additional Context and Ticket
Identified during #417