Fix DBC Identifier Bit Shifting#455
Merged
dchansen06 merged 3 commits intomainfrom May 4, 2026
Merged
Conversation
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
dchansen06
added
Documentation
dchansen06
commented
May 4, 2026
Contributor
Author
dchansen06
left a comment
dchansen06
left a comment
There was a problem hiding this comment.
Randomly chosen identifiers lgtm
dchansen06
added a commit
that referenced
this pull request
May 4, 2026
# DBC Identifier Fix ## Problem and Scope DBC message identifiers are incorrect ## Description Cause by an incorrect bit shifting (`16` instead of `20`) for the sender node ID ## Gotchas and Limitations May be a larger problem but probably not ## Testing - [x] HOOTL testing - [ ] HITL testing - [x] Human tested ### Testing Details Select DBC message identifier fields are correct ## Larger Impact LV testing ## Additional Context and Ticket Found by @an0tv --------- Signed-off-by: Daniel Hansen <dchansen06@gmail.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DBC Identifier Fix
Problem and Scope
DBC message identifiers are incorrect
Description
Cause by an incorrect bit shifting (
16instead of20) for the sender node IDGotchas and Limitations
May be a larger problem but probably not
Testing
Testing Details
Select DBC message identifier fields are correct
Larger Impact
LV testing
Additional Context and Ticket
Found by @an0tv