Fix CAN Filter on ECU and CCU#457
Merged
dchansen06 merged 6 commits intomainfrom May 4, 2026
Merged
Conversation
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Contributor
Author
|
I'll handle merge conflict of this into |
dchansen06
added
Enhancement
dchansen06
added a commit
that referenced
this pull request
May 4, 2026
# CAN Filter Fix ## Problem and Scope Setup for simple non-extended ID with basic filter ## Description Replaced with two extended ID filters on `GRCAN_ALL` and `GRCAN_(E|C)CU` ## Gotchas and Limitations Needs testing of course, getting it into `LV-test` will be helpful ## Testing - [x] HOOTL testing - [ ] HITL testing - [ ] Human tested ### Testing Details Hardware tests pending ## Larger Impact Less interrupts for things we do not care about (but honestly these nodes get most things anyway) ## Additional Context and Ticket Found while investigating #350 --------- Signed-off-by: Daniel Hansen <dchansen06@gmail.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAN Filter Fix
Problem and Scope
Setup for simple non-extended ID with basic filter
Description
Replaced with two extended ID filters on
GRCAN_ALLandGRCAN_(E|C)CUGotchas and Limitations
Needs testing of course, getting it into
LV-testwill be helpfulTesting
Testing Details
Hardware tests pending
Larger Impact
Less interrupts for things we do not care about (but honestly these nodes get most things anyway)
Additional Context and Ticket
Found while investigating #350