Skip to content

ECU Send Calculated Pedal Info#489

Merged
dchansen06 merged 7 commits into
mainfrom
SendPedalInfo
May 22, 2026
Merged

ECU Send Calculated Pedal Info#489
dchansen06 merged 7 commits into
mainfrom
SendPedalInfo

Conversation

@SlowThomas
Copy link
Copy Markdown
Contributor

@SlowThomas SlowThomas commented May 22, 2026

Send Calculated Pedal Info

Problem and Scope

ECU and Debugger related.

Description

Add new fields for brake and accelerator travel in GRCAN_ECU_ANALOG_DATA_MSG

Testing

  • HOOTL testing
  • HITL testing
  • Human tested

Larger Impact

Debugging.

Additional Context and Ticket

ECU Discord Thread

@SlowThomas SlowThomas requested a review from dchansen06 as a code owner May 22, 2026 03:31
@SlowThomas SlowThomas marked this pull request as draft May 22, 2026 03:31
@SlowThomas SlowThomas marked this pull request as ready for review May 22, 2026 04:13
@SlowThomas SlowThomas requested a review from kzwicker as a code owner May 22, 2026 04:13
@SlowThomas SlowThomas self-assigned this May 22, 2026
@SlowThomas SlowThomas added Enhancement New feature or request 2 PRIORITY Important and a priority, but less than URGENT Small Fry Something that is small, could include bug fixes or smaller changes Peripheral Related to or involving a peripheral including abstractions labels May 22, 2026
@SlowThomas SlowThomas added this to the GR26 milestone May 22, 2026
@dchansen06 dchansen06 added the Boards Related to or involving any physical boards label May 22, 2026
Copy link
Copy Markdown
Contributor

@dchansen06 dchansen06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make not part of state data please

Comment thread ECU/Application/Src/CANdler.c
@SlowThomas SlowThomas requested a review from dchansen06 May 22, 2026 04:59
Copy link
Copy Markdown
Contributor

@dchansen06 dchansen06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dchansen06 dchansen06 changed the title Send calculated pedal info ECU Send Calculated Pedal Info May 22, 2026
@dchansen06 dchansen06 merged commit 4885c0c into main May 22, 2026
33 checks passed
@dchansen06 dchansen06 deleted the SendPedalInfo branch May 22, 2026 06:37
dchansen06 pushed a commit that referenced this pull request May 22, 2026
# Send Calculated Pedal Info

## Problem and Scope
ECU and Debugger related.

## Description
Add new fields for brake and accelerator travel in
`GRCAN_ECU_ANALOG_DATA_MSG`

## Testing

- [x] HOOTL testing
- [ ] HITL testing
- [ ] Human tested

## Larger Impact
Debugging.

## Additional Context and Ticket
[ECU Discord
Thread](https://discordapp.com/channels/756738476887638107/1457989718741618788/1507127465548452030)

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 PRIORITY Important and a priority, but less than URGENT Boards Related to or involving any physical boards Enhancement New feature or request Peripheral Related to or involving a peripheral including abstractions Small Fry Something that is small, could include bug fixes or smaller changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants