Tolerate Cache Fails During GitHub Action Runs#497
Merged
Conversation
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make CI runs resilient to intermittent GitHub Actions cache / sccache issues (Issue #496) by making cache-related steps non-fatal and moving sccache enablement into CMake so builds can proceed even when caching infrastructure flakes.
Changes:
- Add automatic
sccachecompiler launcher configuration inCMakeLists.txt(similar structure to existingccachesetup). - Ignore the local
sccache/directory in.gitignore. - Update the UnitTests HOOTL workflow to tolerate failures in cache and
sccachesetup/start steps and stop forcing-DCMAKE_C_COMPILER_LAUNCHER=sccachein CI.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CMakeLists.txt | Auto-detects and configures sccache as a compiler launcher (and sets SCCACHE_DIR). |
| .gitignore | Adds sccache/ to ignored build/cache artifacts. |
| .github/workflows/UnitTestsHOOTL.yml | Makes cache and sccache setup steps non-fatal and removes hard-forcing sccache via a CMake CLI flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
… logs Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache Fails Fine
Problem and Scope
Cache is not perfect and occasionally dies, but it is not key just really nice
Description
Treat
sccachelikeccacheand ensure the CI/CD jobs are not dependent on it passingGotchas and Limitations
Manually must check in and ensure GitHub Action cache is working still
Testing
Testing Details
Ran with
ccache,sccache, and neither locallyLarger Impact
Less intrusive CI/CD jobs
Additional Context and Ticket
Resolves #496