Skip to content

Statistics: PSTH implementation#57

Merged
skim0119 merged 2 commits intoGazzolaLab:update-0.1.1from
armantekinalp:49_PSTH_implementation
Jun 21, 2022
Merged

Statistics: PSTH implementation#57
skim0119 merged 2 commits intoGazzolaLab:update-0.1.1from
armantekinalp:49_PSTH_implementation

Conversation

@armantekinalp
Copy link
Copy Markdown
Collaborator

Fixes #49

PST module, documentation and tests are implemented.

@armantekinalp armantekinalp requested a review from skim0119 June 21, 2022 04:28
@armantekinalp armantekinalp self-assigned this Jun 21, 2022
@armantekinalp armantekinalp added the enhancement New feature or request label Jun 21, 2022
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #57 (06ee97a) into update-0.1.1 (0bbacad) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           update-0.1.1      #57      +/-   ##
================================================
+ Coverage         41.74%   41.98%   +0.24%     
================================================
  Files                24       24              
  Lines               721      724       +3     
  Branches             84       84              
================================================
+ Hits                301      304       +3     
  Misses              418      418              
  Partials              2        2              
Flag Coverage Δ
unittests 41.98% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
miv/statistics/spiketrain_statistics.py 84.00% <100.00%> (+2.18%) ⬆️
miv/datasets/optogenetic.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bbacad...06ee97a. Read the comment docs.

@skim0119 skim0119 changed the title 49 psth implementation 49 pst/h implementation Jun 21, 2022
@skim0119 skim0119 changed the title 49 pst/h implementation [WIP] PSTH implementation Jun 21, 2022
Copy link
Copy Markdown
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skim0119 skim0119 changed the title [WIP] PSTH implementation Statistics: PSTH implementation Jun 21, 2022
@skim0119 skim0119 merged commit c1e4b06 into GazzolaLab:update-0.1.1 Jun 21, 2022
@armantekinalp armantekinalp deleted the 49_PSTH_implementation branch June 23, 2022 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants