Skip to content

Connectivity: Spike triggered average plot#71

Merged
skim0119 merged 24 commits intoGazzolaLab:update-0.1.2from
Gauravu2:spike_triggered_average
Jul 5, 2022
Merged

Connectivity: Spike triggered average plot#71
skim0119 merged 24 commits intoGazzolaLab:update-0.1.2from
Gauravu2:spike_triggered_average

Conversation

@Gauravu2
Copy link
Copy Markdown
Contributor

@Gauravu2 Gauravu2 commented Jun 30, 2022

Function to plot spike triggered average

Remaining work:

  • Documentation and examples
  • Tests

resolve #70

@Gauravu2 Gauravu2 added this to the Version 0.2 milestone Jun 30, 2022
@Gauravu2 Gauravu2 requested a review from skim0119 June 30, 2022 05:16
@Gauravu2 Gauravu2 self-assigned this Jun 30, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #71 (2e4f897) into update-0.1.2 (e0da865) will decrease coverage by 0.37%.
The diff coverage is 33.33%.

@@               Coverage Diff                @@
##           update-0.1.2      #71      +/-   ##
================================================
- Coverage         49.41%   49.04%   -0.38%     
================================================
  Files                31       31              
  Lines              1022     1042      +20     
  Branches            117      118       +1     
================================================
+ Hits                505      511       +6     
- Misses              503      517      +14     
  Partials             14       14              
Flag Coverage Δ
unittests 49.04% <33.33%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
miv/visualization/causality.py 29.16% <33.33%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0da865...2e4f897. Read the comment docs.

@Gauravu2 Gauravu2 added the enhancement New feature or request label Jun 30, 2022
@Gauravu2 Gauravu2 changed the title [WIP] Spike triggered average Spike triggered average Jun 30, 2022
Copy link
Copy Markdown
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Some minor change.

Comment thread miv/visualization/spike_triggered_avg.py Outdated
Comment thread miv/visualization/spike_triggered_avg.py Outdated
Comment thread miv/visualization/spike_triggered_avg.py Outdated
@skim0119 skim0119 linked an issue Jul 2, 2022 that may be closed by this pull request
@skim0119 skim0119 force-pushed the spike_triggered_average branch 11 times, most recently from 5f07f00 to 84d8dcf Compare July 5, 2022 18:57
@skim0119 skim0119 force-pushed the spike_triggered_average branch from 84d8dcf to 0e4bbac Compare July 5, 2022 19:01
@skim0119 skim0119 changed the title Spike triggered average Connectivity: Spike triggered average plot Jul 5, 2022
Copy link
Copy Markdown
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skim0119 skim0119 merged commit 75a93b5 into GazzolaLab:update-0.1.2 Jul 5, 2022
@skim0119 skim0119 mentioned this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spike triggered average

3 participants