Fish swimming case study#6
Merged
Merged
Conversation
Issue: Unit.Simulator.IO.H5.H5Metadata could fail on newer standard libraries because the unqualified call to format(...) becomes ambiguous once std::format is visible. Fix: qualify the call as ::elastica::io::format so metadata naming keeps using the project helper instead of depending on ADL or standard-library lookup.
Issue: the failing Cosserat rod data tests were all exercising Model::initialize(model, std::move(initializer)), but the same initializer object was then repeatedly forwarded as an rvalue through the plugin and component initialization chain. That left later stages reading a moved-from initializer, which is undefined behavior and can show up as GCC-only segfaults or aborts in cross-section and elasticity setup. Fix: keep a stable initializer reference during initialization and update the Cosserat initialize_component helpers to forward references instead of taking the initializer by value. This removes the moved-from reuse and makes geometry and elasticity initialization deterministic across toolchains.
…hether the forcing grid is empty
…oad fish data from datafile
…ation with an adaptive time step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigation of fish swimming in viscous fluid, enabled by
SophT.