Skip to content

Changes to snackplayer and code strict mode #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Changes to snackplayer and code strict mode #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58dba75
Changes to snackplayer and code strict mode
Sep 9, 2021
62e0e9f
Merge branch 'minor' of github.com:GeekyAnts/nativebase-docs into fea…
Sep 9, 2021
a5f4703
v31tov32 slug changed
Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/alertDialog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function AlertDialogComponent() {
<Button ref={cancelRef} onPress={onClose}>
Cancel
</Button>
<Button colorScheme="red" onPress={onClose} ml={3}>
<Button colorScheme="red" onPress={onClose} ml="3">
Delete
</Button>
</AlertDialog.Footer>
Expand All @@ -71,7 +71,7 @@ function AlertDialogComponent() {
export default function () {
return (
<NativeBaseProvider>
<Center flex={1}>
<Center flex="1">
<AlertDialogComponent />
</Center>
</NativeBaseProvider>
Expand Down Expand Up @@ -122,7 +122,7 @@ function AlertDialogComponent() {
export default function () {
return (
<NativeBaseProvider>
<Center flex={1}>
<Center flex="1">
<AlertDialogComponent />
</Center>
</NativeBaseProvider>
Expand Down
4 changes: 2 additions & 2 deletions docs/appDrawer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ function AppDrawer(){
"forum",
];

return <SimpleGrid columns={5} spacingY={4} spacingX={4}>
return <SimpleGrid columns="5" spacingY="4" spacingX="4">
{icons.map((icon) => (
<IconButton
borderRadius="full"
colorScheme="indigo"
variant="solid"
p={4}
p="4"
icon={<Icon name={icon} as={MaterialIcons} size='sm' />}
/>
))}
Expand Down
6 changes: 3 additions & 3 deletions docs/box.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const Example = () => {
end: [1, 0],
},
}}
p={12}
p="12"
rounded="lg"
_text={{
fontSize: "md",
Expand All @@ -63,7 +63,7 @@ const config = {
export default () => {
return (
<NativeBaseProvider config={config}>
<Center flex={1}>
<Center flex="1">
<Example />
</Center>
</NativeBaseProvider>
Expand All @@ -89,7 +89,7 @@ const Example = () => {
end: [1, 0],
},
}}
p={12}
p="12"
rounded="lg"
_text={{ fontSize: 'md', fontWeight: 'bold', color: 'white' }}
>
Expand Down
8 changes: 4 additions & 4 deletions docs/buildingAppBar.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ function AppBar(){

<Box safeAreaTop backgroundColor="#6200ee" />

<HStack bg='#6200ee' px={1} py={3} justifyContent='space-between' alignItems='center'>
<HStack space={4} alignItems='center'>
<HStack bg='#6200ee' px="1" py="3" justifyContent='space-between' alignItems='center'>
<HStack space="4" alignItems='center'>
<IconButton icon={<Icon size="sm" as={<MaterialIcons name='menu' />} color="white" />} />
<Text color="white" fontSize={20} fontWeight='bold'>Home</Text>
<Text color="white" fontSize="20" fontWeight='bold'>Home</Text>
</HStack>
<HStack space={2}>
<HStack space="2">
<IconButton icon={<Icon as={<MaterialIcons name='favorite' />} size='sm' color="white" />} />
<IconButton icon={<Icon as={<MaterialIcons name='search' />}
color="white" size='sm' />} />
Expand Down
66 changes: 33 additions & 33 deletions docs/buildingDrawerNavigation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ import {
const Drawer = createDrawerNavigator();
function Component(props) {
return (
<HStack alignItems="center" mt={6}>
<Pressable onPress={() => props.navigation.toggleDrawer()} position="absolute" ml={2} zIndex={1}>
<HamburgerIcon ml={2} size="sm"/>
<HStack alignItems="center" mt="6">
<Pressable onPress={() => props.navigation.toggleDrawer()} position="absolute" ml="2" zIndex="1">
<HamburgerIcon ml="2" size="sm"/>
</Pressable>
<Center flex={1} >
<Center flex="1" >
<Heading size="md">{props.route.name}</Heading>
</Center>
</HStack>
Expand Down Expand Up @@ -69,72 +69,72 @@ const getIcon = (screenName) => {
function CustomDrawerContent(props) {
return (
<DrawerContentScrollView {...props} safeArea>
<VStack space={6} my={2} mx={1}>
<Box px={4}>
<VStack space="6" my="2" mx="1">
<Box px="4">
<Text bold color="gray.700">Mail</Text>
<Text fontSize={14} mt={1} color="gray.500" fontWeight={500}>john_doe@gmail.com</Text>
<Text fontSize="14" mt="1" color="gray.500" fontWeight="500">john_doe@gmail.com</Text>
</Box>
<VStack divider={<Divider />} space={4}>
<VStack space={3}>
<VStack divider={<Divider />} space="4">
<VStack space="3">
{props.state.routeNames.map((name, index) => (
<Pressable
px={5}
py={3}
px="5"
py="3"
rounded="md"
bg={index === props.state.index ? 'rgba(6, 182, 212, 0.1)' : 'transparent'}
onPress={(event) => {
props.navigation.navigate(name);
}}
>
<HStack space={7} alignItems="center">
<HStack space="7" alignItems="center">
<Icon
color={index === props.state.index ? 'primary.500' : 'gray.500'}
size={5} as={<MaterialCommunityIcons name={getIcon(name)}/>} />
<Text fontWeight={500} color={index === props.state.index ? 'primary.500' : 'gray.700'}>
size="5" as={<MaterialCommunityIcons name={getIcon(name)}/>} />
<Text fontWeight="500" color={index === props.state.index ? 'primary.500' : 'gray.700'}>
{name}
</Text>
</HStack>
</Pressable>
))}
</VStack>
<VStack space={5}>
<Text fontWeight={500} fontSize={14} px={5} color="gray.500">Labels</Text>
<VStack space={3}>
<VStack space="5">
<Text fontWeight="500" fontSize="14" px="5" color="gray.500">Labels</Text>
<VStack space="3">
<Pressable
px={5}
py={3}
px="5"
py="3"
>
<HStack space={7} alignItems="center">
<HStack space="7" alignItems="center">
<Icon
color='gray.500'
size={5} as={<MaterialCommunityIcons name='bookmark'/>} />
<Text color='gray.700' fontWeight={500}>
size="5" as={<MaterialCommunityIcons name='bookmark'/>} />
<Text color='gray.700' fontWeight="500">
Family
</Text>
</HStack>
</Pressable>
<Pressable
px={5}
py={2}
px="5"
py="2"
>
<HStack space={7} alignItems="center">
<HStack space="7" alignItems="center">
<Icon
color='gray.500'
size={5} as={<MaterialCommunityIcons name='bookmark'/>} />
<Text color='gray.700' fontWeight={500}>
size="5" as={<MaterialCommunityIcons name='bookmark'/>} />
<Text color='gray.700' fontWeight="500">
Friends
</Text>
</HStack>
</Pressable>
<Pressable
px={5}
py={3}
px="5"
py="3"
>
<HStack space={7} alignItems="center">
<HStack space="7" alignItems="center">
<Icon
color='gray.500'
size={5} as={<MaterialCommunityIcons name='bookmark'/>} />
<Text fontWeight={500} color='gray.700'>
size="5" as={<MaterialCommunityIcons name='bookmark'/>} />
<Text fontWeight="500" color='gray.700'>
Work
</Text>
</HStack>
Expand All @@ -148,7 +148,7 @@ function CustomDrawerContent(props) {
}
function MyDrawer() {
return (
<Box safeArea flex={1} >
<Box safeArea flex="1" >
<Drawer.Navigator
drawerContent={(props) => <CustomDrawerContent {...props} />}
>
Expand Down
38 changes: 19 additions & 19 deletions docs/buildingFooterTabs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,79 +31,79 @@ export default function App() {
const [selected, setSelected] = React.useState(1);
return (
<NativeBaseProvider>
<Box flex={1} bg="white" safeAreaTop>
<Center flex={1}>
<Box flex="1" bg="white" safeAreaTop>
<Center flex="1">
</Center>
<HStack bg="primary.500" alignItems="center" safeAreaBottom shadow={6}>
<HStack bg="primary.500" alignItems="center" safeAreaBottom shadow="6">
<Pressable
cursor="pointer"
opacity={selected === 0 ? 1 : 0.5}
py={2}
flex={1}
py="2"
flex="1"
onPress={() => setSelected(0)}
>
<Center>
<Icon
mb={1}
mb="1"
as={<MaterialCommunityIcons name="heart" />}
color="white"
size="xs"
/>

<Text color="white" fontSize={14}>Favorites</Text>
<Text color="white" fontSize="14">Favorites</Text>
</Center>
</Pressable>
<Pressable
cursor="pointer"
opacity={selected === 1 ? 1 : 0.5}
py={2}
flex={1}
py="2"
flex="1"
onPress={() => setSelected(1)}
>
<Center>
<Icon
mb={1}
mb="1"
as={<MaterialCommunityIcons name="music-note" />}
color="white"
size="xs"
/>

<Text color="white" fontSize={14}>Music</Text>
<Text color="white" fontSize="14">Music</Text>
</Center>
</Pressable>
<Pressable
cursor="pointer"
opacity={selected === 2 ? 1 : 0.6}
py={2}
flex={1}
py="2"
flex="1"
onPress={() => setSelected(2)}
>
<Center>
<Icon
mb={1}
mb="1"
as={<MaterialIcons name="location-pin" />}
color="white"
size="xs"
/>

<Text color="white" fontSize={14}>Places</Text>
<Text color="white" fontSize="14">Places</Text>
</Center>
</Pressable>
<Pressable
cursor="pointer"
opacity={selected === 3 ? 1 : 0.5}
py={2}
flex={1}
py="2"
flex="1"
onPress={() => setSelected(3)}
>
<Center>
<Icon
mb={1}
mb="1"
as={<MaterialCommunityIcons name="newspaper" />}
color="white"
size="xs"
/>
<Text color="white" fontSize={14}>News</Text>
<Text color="white" fontSize="14">News</Text>
</Center>
</Pressable>
</HStack>
Expand Down
28 changes: 14 additions & 14 deletions docs/buildingSearchBar.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,39 +21,39 @@ import { FontAwesome5 } from '@expo/vector-icons';

function SearchBar(){
return (
<VStack space={8} width="100%">
<VStack width="100%" space={2}>
<VStack space="8" width="100%">
<VStack width="100%" space="2">
<Box>Cupertino</Box>
<Input
placeholder="Search"
variant="filled"
width="100%"
bg="gray.200"
borderRadius={10}
py={1}
px={2}
borderRadius="10"
py="1"
px="2"
_web={{
_focus: { borderColor: 'muted.300', style: { boxShadow: 'none' } },
}}
InputLeftElement={<Icon size='sm' ml={2} size={5} color="gray.400" as={<Ionicons name="ios-search" />} />}
InputLeftElement={<Icon size='sm' ml="2" size="5" color="gray.400" as={<Ionicons name="ios-search" />} />}
/>
</VStack>

<VStack width="100%" space={2}>
<VStack width="100%" space="2">
<Box>Material</Box>
<Input
placeholder="Search People & Places"
bg="#fff"
width="100%"
borderRadius={4}
py={3}
px={1}
fontSize={14}
borderRadius="4"
py="3"
px="1"
fontSize="14"
_web={{
_focus: { borderColor: 'muted.300', style: { boxShadow: 'none' } },
}}
InputLeftElement={<Icon size='sm' m={2} size={6} color="gray.400" as={<MaterialIcons name="search" />} />}
InputRightElement={<Icon size='sm' m={2} size={6} color="gray.400" as={<MaterialIcons name="mic" />} />}
InputLeftElement={<Icon size='sm' m="2" size="6" color="gray.400" as={<MaterialIcons name="search" />} />}
InputRightElement={<Icon size='sm' m="2" size="6" color="gray.400" as={<MaterialIcons name="mic" />} />}
/>
</VStack>
</VStack>
Expand All @@ -63,7 +63,7 @@ function SearchBar(){
export default function () {
return (
<NativeBaseProvider>
<Center flex={1} px={2}>
<Center flex="1" px="2">
<SearchBar/>
</Center>
</NativeBaseProvider>
Expand Down
Loading