fix(revolut): remove blanket digit-prefix crypto classification#157
fix(revolut): remove blanket digit-prefix crypto classification#157
Conversation
Stock tickers like 65C were incorrectly classified as crypto because the heuristic assumed all symbols starting with digits are crypto. 1INCH is already in the KNOWN_CRYPTO set, making the regex redundant.
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sourced from Revolut's published crypto trading list. Covers DeFi, infrastructure tokens, stablecoins, rebrands (MATIC→POL), and historically-available tokens needed for older exports.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 97.62% 97.63% +0.01%
==========================================
Files 37 38 +1
Lines 7585 7622 +37
Branches 1551 1549 -2
==========================================
+ Hits 7405 7442 +37
Misses 179 179
Partials 1 1
🚀 New features to boost your workflow:
|
Replace hardcoded KNOWN_CRYPTO set with a generated file sourced from CoinGecko's top 500 coins by market cap. Stock ticker conflicts (A, B, T, etc.) are excluded at generation time. Run `npx tsx scripts/update-crypto-symbols.ts` to refresh the list.
Summary
65Cwere incorrectly placed under crypto (Modelo 721) instead of stocks (Modelo 720)1INCHand other digit-prefixed crypto are already in theKNOWN_CRYPTOset, making the regex redundantTest plan
65Cis classified asSTK1INCHstill classified asCRYPTO(via KNOWN_CRYPTO set)