fix: prevent PostgreSQL migrations from silently rolling back #71
+30
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
context.configure(), causing Alembic to skip transaction managementpg_advisory_lock()to transaction-scopedpg_advisory_xact_lock()inside thebegin_transaction()blockRoot Cause
The advisory lock in
alembic/env.pywas acquired beforecontext.configure(). This triggered SQLAlchemy's autobegin, which made Alembic detect_in_external_transaction=Trueand returnnullcontext()frombegin_transaction()-- skipping all commit logic. DDL ran but was rolled back on connection close.Test plan
Fixes #70