Jan 14 2023 poole#185
Conversation
Took 1 hour 33 minutes on Bulldozer FX-8120 tests of simple *.c succeeeded on Raspberry Pi 4B.
…otes I had posted so Maffblaster might get some benefit
…mjones advises there is only the "main" branch.
…Pipeline_Jan_02_2023_1602@2\build was not created when it should have been come time to stage the release.
Incomplete notes; safety
moved closing double quote mark to include the double dollar sign. In OpenRC, having the dollar sign outside of the quotation mark causes chroot.py to not find the temporary pid file. (Not fully tested, e.g. going back to original form and generating error and then making change and seeing that the step/task "locale" works as I do not know where the log ares cached and I've asked in Issue #179 and on Discord general chat how to force that particular step to be reprocessed.
Having whitespace before a shebang, "#!", on first line causes QEMU to barf.
|
|
||
| if [[ ! -d "${PROJECT_DIR}/chroot" ]]; then | ||
| mkdir "${PROJECT_DIR}/chroot" | ||
| mkdir -p "${PROJECT_DIR}/chroot" |
There was a problem hiding this comment.
use ckmkdir from scripts/functions.sh instead
There was a problem hiding this comment.
An example, from parsers/emerge
source "$BASEDIR/scripts/functions.sh"
ckmkdir "${BINPKGS_DIR}"
ckmkdir "${DISTFILES_DIR}"
ckmkdir "${PROJECT_DIR}/chroot/var/cache/binpkgs"
ckmkdir "${PROJECT_DIR}/chroot/var/cache/distfiles"
| #Use as a last resort. | ||
| if [[ ! -d "$BINPKGS_DIR" ]]; then | ||
| mkdir "$BINPKGS_DIR" | ||
| mkdir -p "$BINPKGS_DIR" |
There was a problem hiding this comment.
use chmkdir from scripts/functions.sh instead
| wget https://bouncer.gentoo.org/fetch/root/all/releases/${STAGE3_ARCH}/autobuilds/${STAGE3} -O stage3.tar.xz | ||
| fi | ||
| mkdir chroot | ||
| mkdir -p chroot |
There was a problem hiding this comment.
-p is not needed here. The mkdir command runs relative to the current working directory, which, in the context of github actions, always exists unless otherwise deleted.
| fi | ||
| mkdir chroot | ||
| mkdir -p chroot | ||
| pushd chroot |
There was a problem hiding this comment.
unrelated to the -p change, i'm not seeing a big advantage of using pushd over cd.
and i'm also not sure that it makes sense to change directory instead of just telling the tar command to extract directly into the chroot directory.
|
Squash your commits into a single commit. edit the resulting file as appropriate following the in-file instructions |
|
I apologize for the delay. I'm really struggling here to use git. Can you recommend a site which covers git. This try-to-learn git peace-meal as needed simply is not working for me. I'll make a commitment to learn git and do practice stuff with a test repository until I'm satisfied I know what I'm doing in git. I have enough problems with Subversion and branching which I avoid if I can because it just seems to get me into trouble. In the meantime, in the interest of efficiency, perhaps you can effectuate a patch that replaced "mkdir" with your custom chmkdir at the places I identified you agreed needed improvement so the benefit of the change does not get delayed due to my incompetency of using git. |
Maybe this helps: https://www.youtube.com/watch?v=SWYqp7iY_Tc |
Thank you. I'm plowing through https://git-scm.com/book/en/v2. I really won't be able to spend much time until after February 1st, so don't expect anything in the next week. |
|
Excellent sleuthing.
I'm afraid divining whitespace as to whether they are ASCII 32 characters
or tabs belies the fragility of using whitespace whose effect may be
ambiguous. Sharing my criticism reminds me of the lad claiming the
Emperor is not clothed.
…On Sat, Jul 29, 2023 at 8:50 AM kaoru inoue ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In parsers/rawcommand/rawcommand
<#185 (comment)>:
> cat <<- EOF > "${PROJECT_DIR}/chroot/em-$$"
- #!/usr/bin/env bash
@jonesmz <https://github.com/jonesmz> CC: @jlpoolen
<https://github.com/jlpoolen>
Sorry for commenting after so much time.
I came across this comment because I thought it might be a problem with
this file.
The comment at the reference URL ( https://linuxize.com/post/bash-heredoc/
) says the following.
Appending a minus sign to the redirection operator <<-,
This allows you to use indentation.
This allows you to use indentation when writing here-documents in shell scripts.
Leading whitespace characters are not allowed, only tab.
It does remove tabs.
For example, other hear-documents, such as
[Build.Dist/parsers/emerge/emerge](
https://github.com/GenPi64/Build.Dist/blob/5f3eb191034c824034fcd24de85481bdc08
fdfaf/parsers/emerge/emerge#L26) are tabs.
To me it looked like the commit was erasing all whitespace.
But it can also work by changing it to tabs.
—
Reply to this email directly, view it on GitHub
<#185 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXP4O47EZ7ZGG32RFHI23XSUWM7ANCNFSM6AAAAAAT3V2UA4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
John L. Poole
707-812-1323
***@***.***
|
|
Please do whatever will move this issue to a successful resolution. Mike
and I had hoped I would learn about GIT pulls, but since my retirement from
programming six months ago, I have had little gumption to undertake
mastering GIT. Therefore, you offer to create a new and separate pull
request would be a welcomed contribution. Thank you.
https://www.ak-modul-bus.de/
…On Sun, Jul 30, 2023 at 1:17 AM kaoru inoue ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In parsers/rawcommand/rawcommand
<#185 (comment)>:
> cat <<- EOF > "${PROJECT_DIR}/chroot/em-$$"
- #!/usr/bin/env bash
@jlpoolen <https://github.com/jlpoolen> Thank you for your reply!
<#185 (comment)>
(I thought it would be easier to understand the context if I commented on
the corrections, so I'll comment here.)
I agree that spaces and tabs are confusing.
However, I myself feel that it is easier to understand if there is an
indentation.
This rawcommand issue makes image creation difficult, so can I create
another pull request( for this file only )?
—
Reply to this email directly, view it on GitHub
<#185 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXP4OZRHJSOTVDYAH5UC3XSYKBHANCNFSM6AAAAAAT3V2UA4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
John L. Poole
707-812-1323
new email:* ***@***.*** ***@***.***>*
*old gmail.com <http://gmail.com> account is being phased out*
|
|
This is so stale and tin-machine looks to have submitted what was needed; I'm closing this as stale. |
4 participants
I'm submitting 4 files modified:
3 have "-p" added to mkdir.
1 has whitespace before shebang removed.
When I built anew, there was a problem with a subdirectory not being created at first, a bug which would only manifest itself on an initial run. I see no harm in having all mkdirs with -p.