Conversation
samip5
changed the title
jonesmz
reviewed
Oct 13, 2021
jonesmz
reviewed
Oct 13, 2021
jonesmz
reviewed
Oct 13, 2021
| device = p.stdout.read() | ||
| return device.decode('utf-8').strip() | ||
| print(p.stderr.read()) | ||
| rootdelay -= 1 |
There was a problem hiding this comment.
Wouldn't we want to look for the root device on every loop?
Or is that what it's doing and I just don't speak python well enough?
Contributor
Author
There was a problem hiding this comment.
Can't comment on that as I mostly just changed identition and rootwait to rootdelay.
jonesmz
reviewed
Oct 13, 2021
jonesmz
left a comment
jonesmz
left a comment
There was a problem hiding this comment.
Does "rootdelay" automatically imply "rootwait"? it looks like you've removed references to rootwait entirely (I think?)
Also, the indentation of the entire file was changed. If that's intentional, then OK. Just figured I'd point it out.
|
As a minor recommendation, maybe move the whitespace changes to a second commit prior to your logic changes. |
samip5
force-pushed
the
rootwait_to_rootdelay
branch
from
50042a2 to
3503131
Compare
samip5
force-pushed
the
rootwait_to_rootdelay
branch
from
3035c60 to
60e91fd
Compare
perkinslr
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please take a look.