docs: make the correct type of type appear in OpenAPI#1088
Merged
fhennig merged 2 commits intogeneralized-collections-pt1from Mar 19, 2026
Merged
docs: make the correct type of type appear in OpenAPI#1088fhennig merged 2 commits intogeneralized-collections-pt1from
type appear in OpenAPI#1088fhennig merged 2 commits intogeneralized-collections-pt1from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2 tasks
fhennig
approved these changes
Mar 19, 2026
Contributor
|
Thanks for doing this in code right away 🙏 appreciated! |
fhennig
added a commit
that referenced
this pull request
Mar 19, 2026
…1076) * Add tables * add a 'create collection' endpoint * Add 'GET' for collections; add tests * Add setup to spin up local postgres instance for testing * Add 'GET' for collections by ID * foo * change mutation list defintion * Add delete implementation * put pt1 * dedicated Variant.kt api file * Change collection & variant IDs from UUID to Long Collections are unreleased, so we can change in-place with no migration or backwards-compatibility concerns. Switches DB schema to bigserial, ORM tables to LongIdTable, and all API/model/test types from String/UUID to Long. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * review * Consolidate DB setup: use root docker-compose for local dev Remove backend/docker-compose.dev.yaml and update README to use the root compose file's database service. Also align POSTGRES_DB name to dashboards-backend-db across docker-compose.yml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Move validateIsValidOrganism into DashboardsConfig class No need for an extension function when it can be a regular member. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix variant deletion in putCollection and clean up imports Use VariantTable.deleteWhere with explicit column references to avoid ambiguity between the 'id' function parameter and the table's id column. Add exposed-jdbc dependency and required imports. Remove stale validateIsValidOrganism extension function imports. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Extract duplicated lineage filter validation into a single method Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * optimize collection loading * better MutationListDefinition * Update backend/src/test/kotlin/org/genspectrum/dashboardsbackend/controller/CollectionsControllerTest.kt Co-authored-by: Fabian Engelniederhammer <92720311+fengelniederhammer@users.noreply.github.com> * some progress, but failing tests * simplify Mutationlist * Use import for MutationListDefinition in VariantTable Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Add doc comment to validateLineageFilters Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Reduce duplication by routing createCollection through createVariantEntity Add VariantUpdate.toVariantRequest() for the id-null case, and change createVariantEntity to accept VariantRequest, removing the need for a runtime id check. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Use when expression to capture variantId in putCollection Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Split CollectionsControllerTest by HTTP verb Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Rename test to follow GIVEN/WHEN/THEN convention Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Use imports instead of fully-qualified names in CollectionsPostTest Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Add test asserting type field is present on variants in GET response Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Add type field to VariantRequest subclasses for consistency with Variant Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Revert "Add type field to VariantRequest subclasses for consistency with Variant" This reverts commit 513ad8c. * format * docs: make the correct type of `type` appear in OpenAPI (#1088) * docs: make the correct type of `type` appear in OpenAPI * fix import * Add test * Remove unused function * remove explicit spring JDBC import * remove unused exception handler --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Fabian Engelniederhammer <92720311+fengelniederhammer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addressing https://github.com/GenSpectrum/dashboards/pull/1076/changes#r2945154292
Screenshot
PR Checklist
- [ ] All necessary documentation has been adapted.- [ ] The implemented feature is covered by an appropriate test.