-
Notifications
You must be signed in to change notification settings - Fork 0
refactor(website): replace hardcoded wasapPageConfig references with config struct referenced by organism name #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1273e74 to
3f2afd9
Compare
…type that gets passed in
3f2afd9 to
5c91976
Compare
fengelniederhammer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6747ced to
f12af41
Compare
a186ead to
6599b49
Compare
6599b49 to
e7130dd
Compare
e7130dd to
5683376
Compare
5683376 to
4371493
Compare
|
@fengelniederhammer can you have another look? I merged the resistance mutation stuff in, but then I also noticed that the defaults contained organism-specific stuff, so I also moved the defaults into the config. |
This is prep work for being able to more easily add more W-ASAP dashboards for other organisms, like RSV-A.
Summary
WasapPageConfigwhich theWasapPageuses and passes down to sub componentsWasap.astrowhere you only pass in an organism name to get the whole dashboard configured.wasapsection in thewastewaterConfigWasapAnalysisFiltertypes also into thewastewaterConfigfileWasapPageConfigScreenshot
n/A, looks identical
PR Checklist
The implemented feature is covered by an appropriate test.(We already have tests)