Skip to content

Conversation

@fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 2, 2025

This is prep work for being able to more easily add more W-ASAP dashboards for other organisms, like RSV-A.

Summary

  • create a new type WasapPageConfig which the WasapPage uses and passes down to sub components
  • create a new Wasap.astro where you only pass in an organism name to get the whole dashboard configured.
  • removes old wasap section in the wastewaterConfig
  • create covid W-ASAP config with new type to configure the current dashboard
  • make the analysis modes which are enabled configurable, because for RSV-A we will not want all of the ones we currently have
  • move all WasapAnalysisFilter types also into the wastewaterConfig file
  • move filter default configurations also into the WasapPageConfig

Screenshot

n/A, looks identical

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test. (We already have tests)

@vercel
Copy link

vercel bot commented Dec 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
dashboards Ready Ready Preview Comment Dec 4, 2025 11:40am

@fhennig fhennig self-assigned this Dec 2, 2025
@fhennig fhennig changed the title refactor: replace hardcoded wasapPageConfig references with type that gets passed in refactor(website): replace hardcoded wasapPageConfig references with type that gets passed in Dec 2, 2025
@fhennig fhennig force-pushed the refactor-wasap-page-config branch from 1273e74 to 3f2afd9 Compare December 2, 2025 17:31
@fhennig fhennig changed the title refactor(website): replace hardcoded wasapPageConfig references with type that gets passed in refactor(website): replace hardcoded wasapPageConfig references with config struct referenced by organism name Dec 3, 2025
Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhennig
Copy link
Contributor Author

fhennig commented Dec 4, 2025

@fengelniederhammer can you have another look? I merged the resistance mutation stuff in, but then I also noticed that the defaults contained organism-specific stuff, so I also moved the defaults into the config.

@fhennig fhennig merged commit a3d5b60 into main Dec 5, 2025
9 checks passed
@fhennig fhennig deleted the refactor-wasap-page-config branch December 5, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants