-
Notifications
You must be signed in to change notification settings - Fork 8
Refactor attributions #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MuhammedHasan
merged 9 commits into
Genentech:refactor
from
MuhammedHasan:refactor-attributions
May 28, 2025
Merged
Refactor attributions #8
MuhammedHasan
merged 9 commits into
Genentech:refactor
from
MuhammedHasan:refactor-attributions
May 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkanche
reviewed
May 14, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also start adding tests as we go so we are not overwhelmed at the end
Otherwise looks great!
jkanche
approved these changes
May 20, 2025
avantikalal
pushed a commit
that referenced
this pull request
Jun 18, 2025
* setting up the folder structure * move scripts to cli and setting up package meta for cli access * restructure the rest of the files * Refactor attributions (#8) * attribution refactoring low level api design * updates of api of attirbutions and cli * attribution cli * wandb login, resources -> hub, and depreated tools.interpret * update for multiple genes * cli update to support multiple genes and attribution methods * testcase fix * test ci fix * genome --------- Co-authored-by: Muhammed Hasan Celik <muhammedhasancelik@gmail.com> * vep added * vep implemented * vep logs and api update * decima vep bug fix * bug fix * tangermeme version * ci * attr window bug * fix of typo and depreceated * mutate function deleted and fix of string literal * Refactor vep (#9) * vep added * vep implemented * vep logs and api update * decima vep bug fix * bug fix * tangermeme version * ci * attr window bug * fix of typo and depreceated * mutate function deleted and fix of string literal --------- Co-authored-by: Muhammed Hasan Celik <celik.muhammed_hasan@gene.com> * pr code review --------- Co-authored-by: Muhammed Hasan Celik <muhammedhasancelik@gmail.com> Co-authored-by: Muhammed Hasan Celik <celik.muhammed_hasan@gene.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.