fix: second build fails with DirectoryNotFoundException#25
Merged
Conversation
- Replace emoji with PathGeometry icons (Sun/Moon/Globe) - Theme: Moon icon in light mode, Sun icon in dark mode (toggled via IsDarkTheme) - Locale: Globe icon overlay with EN/中 text label - Remove ThemeButtonText emoji property from ViewModel
…d failure - After first build, OutputPath was set to the .zip file path - Second build used it as a directory, creating a broken path - Fix: don't overwrite OutputPath with .zip, keep it as directory only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: after first build, Config.OutputPath was written with the .zip file path (e.g. C:\Users\...\patch.zip). On second build, it was used as the output directory, resulting in path like C:\...\patch.zip\patch.zip.
Fix: remove Config.OutputPath = zip assignment after build completes. OutputPath stays as the user-selected directory (or empty → falls back to Desktop).