refactor: merge GeneralClientBootstrap into GeneralUpdateBootstrap via AppType (#344)#345
Merged
Merged
Conversation
…a AppType - Added AppType dispatch in LaunchAsync(): ClientApp vs UpgradeApp - Merged client-side features: Bowl process mgmt, custom options, dual version validation, CheckFail, ProcessInfo IPC creation, Silent mode, UpdatePrecheck, StartApp - Added AddListenerUpdatePrecheck(), AddCustomOption() to unified API - Marked GeneralClientBootstrap as [Obsolete] with migration guidance - Full solution builds with 0 errors, 0 warnings Closes #344
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates the \GeneralClientBootstrap\ / \GeneralUpdateBootstrap\ duality. All client-side functionality is merged into \GeneralUpdateBootstrap, dispatched by \AppType\ (ClientApp vs UpgradeApp).
Changes
GeneralUpdateBootstrap (unified)
GeneralClientBootstrap
Verification
Migration Guide
`csharp
// Before
new GeneralClientBootstrap().SetConfig(cfg).LaunchAsync();
// After
new GeneralUpdateBootstrap()
.Option(UpdateOptions.AppType, AppType.ClientApp)
.SetConfig(cfg)
.LaunchAsync();
`
Closes #344