refactor: Phase 1b — extract ClientUpdateStrategy and UpgradeUpdateStrategy (#354)#355
Merged
Merged
Conversation
…rategy
- Created ClientUpdateStrategy : IStrategy — encapsulates client workflow
(version validation, dual-version check, Bowl mgmt, custom options,
ProcessInfo IPC creation, backup, download, pipeline execution, StartApp)
- Created UpgradeUpdateStrategy : IStrategy — encapsulates upgrade workflow
(Default/Scripts mode, version validation, backup, download, pipeline)
- Bootstrap.LaunchAsync() now delegates to role strategies via AppType
- Bootstrap simplified to ~220 lines (down from ~560)
- All three role strategies implement IStrategy with Create(GlobalConfigInfo)
Architecture: ClientUpdateStrategy | UpgradeUpdateStrategy | OSSUpdateStrategy
└── composes OS strategy (Windows/Linux/Mac)
Closes #354
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts role-based strategies from Bootstrap inline methods. Completes the 3-role strategy system from section 2.3.
Changes
New:
ClientUpdateStrategy : IStrategy.UseUpdatePrecheck()and.UseCustomOption()for extensibilityNew:
UpgradeUpdateStrategy : IStrategySimplified:
GeneralUpdateBootstrapLaunchAsync()dispatches by AppType → creates role strategy → callsCreate()+ExecuteAsync()LaunchClientAsync,LaunchUpgradeAsync,ExecuteClientWorkflowAsync,ExecuteUpgradeWorkflowAsync) removedArchitecture after Phase 1b
Verification
Closes #354