Skip to content

Batch 1: Clean up legacy code and fix strategy workflows#362

Merged
JusterZhu merged 1 commit into
masterfrom
batch-1-cleanup-legacy
May 24, 2026
Merged

Batch 1: Clean up legacy code and fix strategy workflows#362
JusterZhu merged 1 commit into
masterfrom
batch-1-cleanup-legacy

Conversation

@JusterZhu
Copy link
Copy Markdown
Collaborator

Summary

First batch of the GeneralUpdate refactor plan. Cleans up legacy code and fixes strategy workflows.

Changes

  1. Remove deprecated GeneralClientBootstrap
  2. Refactor UpgradeUpdateStrategy to zero-network — no version validation or downloads
  3. Add macOS MacStrategy support to OS resolution
  4. Replace Process.Kill() with GracefulExit for graceful shutdown

Build

  • dotnet build src/c#/GeneralUpdate.Core — 0 errors
  • dotnet build src/c#/GeneralUpdate.slnx — 0 errors

Closes #361

- Remove deprecated GeneralClientBootstrap class (#361)
- Refactor UpgradeUpdateStrategy to zero-network design:
  Remove version validation and download logic
  Upgrade only applies pipeline and starts main app
- Add macOS (MacStrategy) support to OS resolution
  in both ClientUpdateStrategy and UpgradeUpdateStrategy
- Replace all Process.Kill() calls with GracefulExit
  for graceful process shutdown with timeout fallback

Closes #361
Copilot AI review requested due to automatic review settings May 24, 2026 09:56
@JusterZhu JusterZhu merged commit 83ba93d into master May 24, 2026
1 check failed
@JusterZhu JusterZhu deleted the batch-1-cleanup-legacy branch May 24, 2026 09:57
@JusterZhu JusterZhu review requested due to automatic review settings May 24, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Batch 1: Clean up legacy code and fix strategy workflows

1 participant