Open
Conversation
HenryCaldwell
temporarily deployed
to
supabase-testing
GitHub Actions
Inactive
HenryCaldwell
temporarily deployed
to
supabase-testing
GitHub Actions
Inactive
HenryCaldwell
temporarily deployed
to
supabase-testing
GitHub Actions
Inactive
HenryCaldwell
temporarily deployed
to
supabase-testing
GitHub Actions
Inactive
bamarler
requested changes
Mar 24, 2026
Collaborator
bamarler
left a comment
bamarler
left a comment
There was a problem hiding this comment.
Overall great work! Along with the minor type changes, since you have added tests, some main functions at the bottoms of the scripts are redundant. Can you clean these up please?
HenryCaldwell
temporarily deployed
to
supabase-testing
GitHub Actions
Inactive
HenryCaldwell
temporarily deployed
to
supabase-testing
GitHub Actions
Inactive
HenryCaldwell
temporarily deployed
to
supabase-testing
GitHub Actions
Inactive
HenryCaldwell
temporarily deployed
to
supabase-testing
GitHub Actions
Inactive
bamarler
requested changes
Mar 26, 2026
Collaborator
bamarler
left a comment
bamarler
left a comment
There was a problem hiding this comment.
All of the fixes look good, but I think you edited run_service.py unnecessarily
Collaborator
There was a problem hiding this comment.
Not sure why this file got changed. get_run_metrics() already returns a list[RunResponse], so you're just casting it to itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #94
What changed:
Added unit tests for all util functions and integration tests for athlete, run, and hurdle routes. Fixed a bug in transform_feet_to_stride_cycles where no-contact input caused a KeyError on stride_num.
Why:
Test framework had only example tests, added real coverage.
Technical decisions worth noting:
CSV upload and auth route tests were left untouched.