The oleron did not actually have a zero entry despite HINGE = 0#2004
Merged
PaulWessel merged 6 commits into6.0from Nov 8, 2019
Merged
The oleron did not actually have a zero entry despite HINGE = 0#2004PaulWessel merged 6 commits into6.0from
PaulWessel merged 6 commits into6.0from
Conversation
We require a z == 0 slice for HINGE == 0 to work. Fixes issue reported in the forum: https://forum.generic-mapping-tools.org/t/setting-a-color-hinge-for-oleron-color-palette-table-cpt/74
The rest were OK
seisman
reviewed
Nov 8, 2019
seisman
reviewed
Nov 8, 2019
share/cpt/cork.cpt
Outdated
| @@ -141,7 +141,8 @@ | |||
| -0.019608 229/237/238 -0.011764 230/238/238 | |||
| -0.011764 230/238/238 -0.003922 230/238/237 | |||
| -0.003922 230/238/237 0.003922 231/239/237 | |||
Member
There was a problem hiding this comment.
Suggested change
| -0.003922 230/238/237 0.003922 231/239/237 |
Member
There was a problem hiding this comment.
This change is incorrect. There are duplicated records for -0.003922 to 0.003922.
Member
Author
|
Give me an hour, driving home...
Paul Wessel, Professor and Chair
Dept. of Earth Sciences (formerly Geology & Geophysics)
SOEST, U of Hawaii at Manoa
…On November 7, 2019 at 7:41:46 PM, Dongdong Tian ***@***.***) wrote:
***@***.**** commented on this pull request.
------------------------------
In share/cpt/berlin.cpt
<#2004 (comment)>
:
> @@ -140,7 +140,8 @@
-0.027450 21/14/14 -0.019608 22/14/13
-0.019608 22/14/13 -0.011764 23/13/11
-0.011764 23/13/11 -0.003922 24/12/10
--0.003922 24/12/10 0.003922 25/12/9
+-0.003922 24/12/10 0 25/12/9
The change still doesn't make sense to me.
The original z-slice is -0.003922 24/12/10 0.003922 25/12/9. The color of
z=0 should be an interpolated color of 24/12/10 and 25/12/9, right?
------------------------------
In share/cpt/cork.cpt
<#2004 (comment)>
:
> @@ -141,7 +141,8 @@
-0.019608 229/237/238 -0.011764 230/238/238
-0.011764 230/238/238 -0.003922 230/238/237
-0.003922 230/238/237 0.003922 231/239/237
⬇️ Suggested change
- -0.003922 230/238/237 0.003922 231/239/237
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2004?email_source=notifications&email_token=AGJ7IX6GVF6X2DMAUNI2MXTQST3ZVA5CNFSM4JKSVUXKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCK2BESA#pullrequestreview-313791048>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJ7IXZ4FKH5REJTTLUVDQDQST3ZVANCNFSM4JKSVUXA>
.
|
Member
|
I'm also very confused about hinge. From what I understand, hinge is only needed when a CPT has a color discontinuity at z=0 (i.e. CPT for earth relief). Of the 7 CPTs changed in this PR, only oleron is discontinuous at z=0, while all others are continuous. |
Member
Author
|
Continuous yes, but note that they (berlin, broc, cork, lisbon, roma, tofino) all goes through either a near-white or near-black middle value with either lighter/darker on each side or different shades of two different colors. These are all meant to have a hinge even though there is no jump at zero. |
seisman
reviewed
Nov 8, 2019
share/cpt/cork.cpt
Outdated
| @@ -141,7 +141,8 @@ | |||
| -0.019608 229/237/238 -0.011764 230/238/238 | |||
| -0.011764 230/238/238 -0.003922 230/238/237 | |||
| -0.003922 230/238/237 0.003922 231/239/237 | |||
Member
There was a problem hiding this comment.
This change is incorrect. There are duplicated records for -0.003922 to 0.003922.
seisman
approved these changes
Nov 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We require a z == 0 slice for HINGE == 0 to work. Fixes issue reported in the forum: https://forum.generic-mapping-tools.org/t/setting-a-color-hinge-for-oleron-color-palette-table-cpt/74