Skip to content

Fixing miscellaneous issues in gmtregress#3213

Merged
PaulWessel merged 5 commits into
masterfrom
regress-pearson
May 1, 2020
Merged

Fixing miscellaneous issues in gmtregress#3213
PaulWessel merged 5 commits into
masterfrom
regress-pearson

Conversation

@PaulWessel
Copy link
Copy Markdown
Member

@PaulWessel PaulWessel commented May 1, 2020

Description of proposed changes

Some issues have come to light via this forum post that required some changes:

  1. Except for regular regression with misfit measured vertically (-Ey), the Pearsonian coefficient of determination R is not defined (perhaps it is, but not by the same equation; my Google search could not find an equivalent expression for RMA and Ortho regressions - let me know if you can). The output for the userʻs case gave wild R. I now only output R for -Ey.
  2. The RLS algorithm of dividing the search angle range by 2 etc. could stop the search too early if the second iteration visited the same (crude) angle step and that happened to be the smallest misfit yet. Then there would be no drop in best misfit and iterations would stop. I know ensure that this cannot happen until the angle step in the search is at least < 0.05 degrees.
  3. The latter change refined the fits in minor ways for three examples and hence their PS files have been updated.

PaulWessel added 4 commits May 1, 2020 10:44
gmtregress would report the linear correlation coefficient r and the coefficient of determination R but these are really only correctlyl evaluated for standard regression (misfit measured in y-direction only).  Thus, I have removed their misleading output for other regressions.  Also, there was a bug for RLS when r and R was computed twice (and the second time the bad points were back in there...).
@PaulWessel PaulWessel requested review from joa-quim and seisman May 1, 2020 21:08
@PaulWessel
Copy link
Copy Markdown
Member Author

Actually, will let r be printed since it is entirely data driven. But R is wrong (going negative).

@PaulWessel PaulWessel merged commit d4d4d6b into master May 1, 2020
@PaulWessel PaulWessel deleted the regress-pearson branch May 1, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants