Merged
Conversation
The NORM operator in g??math says it will convert A so that max(A)-min(A) = 1. This it does, but not it a good way. For instance, if your data set generally goes from 3.0 to 3.5 and you call NORM, you get a result that goes from 6-7 instead - hardly a useful transformation. What is needed of course is to say that NORM converts A so that min(A) = 0 and max(A) = 1. This bug (and bad documentation) has now been fixed for both grdmath and gmtmath with this PR.
joa-quim
approved these changes
Apr 8, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NORM operator in grdmath* and gmtmath says it will convert A so that
max(A)-min(A) = 1. This it does, but not it a good way. For instance, if your data set generally goes from 3.0 to 3.5 and you call NORM, you get a result that goes from 6-7 instead - hardly a useful transformation. What is needed of course is to say that NORM converts A so thatmin(A) = 0andmax(A) = 1. This bug (and bad documentation) has now been fixed for both grdmath and gmtmath with this PR.No tests were affected. Here is what it used to look like:
and this is after the fix