Fix -R parsing check for geographic data#6536
Merged
PaulWessel merged 2 commits intomasterfrom Apr 8, 2022
Merged
Conversation
We correctlyl detect if the -R string is using recocognized longitude and latitude formats, but then we had a bad check were we needed a bit-wise oeprator obut instead did an equal, i.e. col_type == GMT_IS_GEO instead of col_type & GMT_IS_GEO and we did this because we called a macro to get the type and hence did not try the bitwise and I guess. This now sets geographic internally.
maxrjones
approved these changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During parsing we correctly detect if the -R string is using recognized longitude and latitude formats, but then we had a bad check were we needed a bit-wise operator but instead did an equal, i.e.
col_type == GMT_IS_GEOinstead of
col_type & GMT_IS_GEOand we did this because we called a macro to get the type and hence did not try the bitwise and I guess.
This PR now uses intermediate variables that we can check with and now sets geographic internally.