Conversation
PaulWessel
approved these changes
Jun 29, 2022
Member
PaulWessel
left a comment
PaulWessel
left a comment
There was a problem hiding this comment.
Leave it as this for now but need to go back and fix later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this forum post for reference. Basically the story is this (also added as comment in code)
For some historical reason the parser only reads the strict number of columns needed for each convention and if there are more they are left as text. When it's asked to plot an offset ball the plotting coords are scanned from the remaining text (the n_scanned = sscanf(...) above). But from externals all numeric columns were read and the fishing in text fails resulting in no offset. Applied a patch that solves the issue but it's only that a dumb patch. Better would be to solve in origin but that's risky.