Fix test/gmtest.in so that subplot-l2s.sh and inset-l2s.sh pass#8430
Merged
Fix test/gmtest.in so that subplot-l2s.sh and inset-l2s.sh pass#8430
Conversation
joa-quim
approved these changes
Apr 8, 2024
Member
joa-quim
left a comment
There was a problem hiding this comment.
It still fails for me on Windows
Member
Author
What's the output if you run |
Member
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8430 +/- ##
==========================================
- Coverage 50.49% 50.46% -0.04%
==========================================
Files 262 262
Lines 189043 189043
Branches 43645 43649 +4
==========================================
- Hits 95461 95401 -60
- Misses 77023 77064 +41
- Partials 16559 16578 +19 ☔ View full report in Codecov by Sentry. |
Member
|
Thanks, it works now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subplot-l2s.shandinset-l2s.shfail because these scripts havegmt beginbut don't produce any PS files. Thuspscmpfunction ingmtestexits with an error.This PR fixes it by checking pattern
gmt begin fignamerather thangmt begin.Closes #8344.