Skip to content

Fix test/gmtest.in so that subplot-l2s.sh and inset-l2s.sh pass#8430

Merged
seisman merged 5 commits intomasterfrom
fix-gmtest
Apr 8, 2024
Merged

Fix test/gmtest.in so that subplot-l2s.sh and inset-l2s.sh pass#8430
seisman merged 5 commits intomasterfrom
fix-gmtest

Conversation

@seisman
Copy link
Copy Markdown
Member

@seisman seisman commented Apr 8, 2024

subplot-l2s.sh and inset-l2s.sh fail because these scripts have gmt begin but don't produce any PS files. Thus pscmp function in gmtest exits with an error.

This PR fixes it by checking pattern gmt begin figname rather than gmt begin.

Closes #8344.

Copy link
Copy Markdown
Member

@joa-quim joa-quim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still fails for me on Windows

@seisman
Copy link
Copy Markdown
Member Author

seisman commented Apr 8, 2024

It still fails for me on Windows

What's the output if you run grep -c "gmt begin .*\| -ps \| -view " test/subplot/subplot-l2s.sh?

@joa-quim
Copy link
Copy Markdown
Member

joa-quim commented Apr 8, 2024

C:\v\build>grep -c "gmt begin .*\| -ps \| -view " test/subplot/subplot-l2s/subplot-l2s.sh
0

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.46%. Comparing base (4cb3ca7) to head (e887545).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8430      +/-   ##
==========================================
- Coverage   50.49%   50.46%   -0.04%     
==========================================
  Files         262      262              
  Lines      189043   189043              
  Branches    43645    43649       +4     
==========================================
- Hits        95461    95401      -60     
- Misses      77023    77064      +41     
- Partials    16559    16578      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joa-quim
Copy link
Copy Markdown
Member

joa-quim commented Apr 8, 2024

Thanks, it works now.

@seisman seisman changed the title WIP: Fix test/gmtest.in so that subplot-l2s.sh and inset-l2s.sh pass Fix test/gmtest.in so that subplot-l2s.sh and inset-l2s.sh pass Apr 8, 2024
@seisman seisman added the maintenance Boring but important stuff for the core devs label Apr 8, 2024
@seisman seisman added this to the 6.6.0 milestone Apr 8, 2024
@seisman seisman marked this pull request as ready for review April 8, 2024 13:08
@seisman seisman merged commit 9a6c726 into master Apr 8, 2024
@seisman seisman deleted the fix-gmtest branch April 8, 2024 13:09
joa-quim added a commit that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test/inset/inset-l2s.sh fails

3 participants